feat(Algebra/Adjoin): CoeT instances for Algebra.adjoin on singletons#36439
Open
xgenereux wants to merge 2 commits intoleanprover-community:masterfrom
Open
feat(Algebra/Adjoin): CoeT instances for Algebra.adjoin on singletons#36439xgenereux wants to merge 2 commits intoleanprover-community:masterfrom
xgenereux wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
PR summary 34f85c5f24Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
|
This pull request has conflicts, please merge |
mathlib-merge-conflicts
bot
added
the
merge-conflict
github-actions
bot
removed
the
merge-conflict
Multramate
added
t-algebra
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is it a common occurrence that I need to consider an element
xor some polynomial evaluated inx,p.eval xas an element ofAlgebra.adjoin R {x}.This makes it so that we can write
(x : adjoin R {x})instead of⟨x, self_mem_adjoin_singleton A x⟩(p.eval x : adjoin R {x})instead of⟨p.aeval x, aeval_mem_adjoin_singleton A x⟩This is particularly useful when we need to write the type anyways, so that we need not to write
(⟨p.aeval x, aeval_mem_adjoin_singleton A x⟩ : adjoin R {x})anymore.Co-authored-by: María Inés de Frutos Fernández <[email protected]>