[Merged by Bors] - chore(NumberTheory/NumberField): move number field completion material to new subdir#36393
Closed
smmercuri wants to merge 4 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore(NumberTheory/NumberField): move number field completion material to new subdir#36393smmercuri wants to merge 4 commits intoleanprover-community:masterfrom
smmercuri wants to merge 4 commits intoleanprover-community:masterfrom
Conversation
9 tasks
PR summary 5c8398df52Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
github-actions
bot
added
the
t-number-theory
|
This pull request has conflicts, please merge |
mathlib-merge-conflicts
bot
added
the
merge-conflict
github-actions
bot
removed
the
merge-conflict
Contributor
|
Seems fine to me. maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by tb65536. trigger_name: issue_comment |
mathlib-triage
bot
added
the
maintainer-merge
Member
|
Why not, thanks! bors merge |
mathlib-triage
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 14, 2026
…l to new subdir (#36393)
Contributor
|
Pull request successfully merged into master. Build succeeded:
|
mathlib-bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason for this move is that in a dependent PR #30551 I have some results on the ramification theory of infinite place completions which should really go in
NumberTheory/NumberField/InfinitePlace/Ramification.leanbut there is a circular dependence betweenInfinitePlace/Completion.leanandInfinitePlace/Ramification.leanthat is difficult to resolve. AlsoInfinitePlace/Ramification.leanis getting quite long. So it seems like the best way to fix it is to create a separateCompletionsubdirectory.