Skip to content

[Merged by Bors] - feat(NumberField/InfinitePlace/Ramification): add cardinality results for (un)ramified places over#36353

Closed
smmercuri wants to merge 13 commits intoleanprover-community:masterfrom
smmercuri:ramificationPlacesOverCard
Closed

[Merged by Bors] - feat(NumberField/InfinitePlace/Ramification): add cardinality results for (un)ramified places over#36353
smmercuri wants to merge 13 commits intoleanprover-community:masterfrom
smmercuri:ramificationPlacesOverCard

Conversation

@smmercuri
Copy link
Copy Markdown
Collaborator

@smmercuri smmercuri commented Mar 8, 2026

The number of unramified/ramified places over a fixed infinite place v is equal/twice the number of unmixed/mixed complex embeddings over v.embedding

Open in Gitpod

@smmercuri smmercuri mentioned this pull request Mar 8, 2026
Open
9 tasks
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 8, 2026 •
edited
Loading

PR summary 9d9eb9fb47

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Function.Injective.ite
+ IsRamified.liesOver_isReal_under
+ IsUnramified.liesOver_isReal_over
+ LiesOver.over_apply
+ bijOn_extensionIte
+ bijOn_sumElim_conjugate
+ embeddingConjugateIte
+ embeddingConjugateIte_neg
+ embeddingConjugateIte_pos
+ liesOver_iff
+ mapsTo_embeddingConjugateIte
+ ncard_sumEquiv_symm_apply
+ ramifiedPlacesOver_ncard
+ surjOn_embeddingConjugateIte
+ unramifedPlacesOver_ncard_add_eq_finrank
+ unramifiedPlacesOver_ncard

You can run this locally as follows 
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Mar 8, 2026
MichaelStollBayreuth
MichaelStollBayreuth reviewed Mar 13, 2026
View reviewed changes
@MichaelStollBayreuth MichaelStollBayreuth added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 13, 2026
@smmercuri smmercuri removed the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 15, 2026
@MichaelStollBayreuth
Copy link
Copy Markdown
Contributor

MichaelStollBayreuth commented Mar 15, 2026

Modulo adding sections as suggested in my last comment, LGTM.

maintainer delegate

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 15, 2026

🚀 Pull request has been placed on the maintainer queue by MichaelStollBayreuth.

trigger_name: issue_comment
wf_run: workflow_run

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Mar 15, 2026
jcommelin
jcommelin reviewed Mar 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Mar 21, 2026
@mathlib-triage mathlib-triage bot removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Mar 21, 2026
mathlib-bors bot pushed a commit that referenced this pull request Mar 21, 2026
@smmercuri
feat(NumberField/InfinitePlace/Ramification): add cardinality results…
e5cf50d 
… for (un)ramified places over (#36353)

The number of unramified/ramified places over a fixed infinite place `v` is equal/twice the number of unmixed/mixed complex embeddings over `v.embedding`
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 21, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(NumberField/InfinitePlace/Ramification): add cardinality results for (un)ramified places over [Merged by Bors] - feat(NumberField/InfinitePlace/Ramification): add cardinality results for (un)ramified places over Mar 21, 2026
@mathlib-bors mathlib-bors bot closed this Mar 21, 2026
justus-springer pushed a commit to justus-springer/mathlib4 that referenced this pull request Mar 28, 2026
@smmercuri @justus-springer
feat(NumberField/InfinitePlace/Ramification): add cardinality results…
07707dc 
… for (un)ramified places over (leanprover-community#36353)

The number of unramified/ramified places over a fixed infinite place `v` is equal/twice the number of unmixed/mixed complex embeddings over `v.embedding`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcommelin jcommelin jcommelin left review comments

@tb65536 tb65536 tb65536 left review comments

@MichaelStollBayreuth MichaelStollBayreuth MichaelStollBayreuth left review comments

Assignees

@MichaelStollBayreuth MichaelStollBayreuth

Labels

ready-to-merge This PR has been sent to bors. t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@smmercuri @MichaelStollBayreuth @jcommelin @tb65536