You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Dot notation for concrete Weierstrass curves (Affine/Jacobian/Projective) does not quite work on W : WeierstrassCurve F even though they're all abbreviations of WeierstrassCurve, which is annoying for functions that return WeierstrassCurves (currently just map, baseChange, and variableChange). For instance, for an A : Affine F, the expression A.baseChange K is a WeierstrassCurve K rather than an Affine K, so (A.baseChange K).polynomial will not work since polynomial is a function of Affine K rather than WeierstrassCurve K; instead we have to do (A.baseChange K).toAffine.polynomial, which is wordy. This PR introduces abbreviations Affine/Jacobian/Projective.map/baseChange to get around this, and introduces scoped notations W/K, where the slashes are given by \textf. The notation W⟮K⟯ for (W.baseChange K)Point seems to be useless so far and can now be replaced by (W/K).Point.
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>
The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.
The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
the
merge-conflict
Dot notation for concrete Weierstrass curves (
Affine/Jacobian/Projective) does not quite work onW : WeierstrassCurve Feven though they're all abbreviations ofWeierstrassCurve, which is annoying for functions that returnWeierstrassCurves (currently justmap,baseChange, andvariableChange). For instance, for anA : Affine F, the expressionA.baseChange Kis aWeierstrassCurve Krather than anAffine K, so(A.baseChange K).polynomialwill not work sincepolynomialis a function ofAffine Krather thanWeierstrassCurve K; instead we have to do(A.baseChange K).toAffine.polynomial, which is wordy. This PR introduces abbreviationsAffine/Jacobian/Projective.map/baseChangeto get around this, and introduces scoped notationsW/K, where the slashes are given by\textf. The notationW⟮K⟯for(W.baseChange K)Pointseems to be useless so far and can now be replaced by(W/K).Point.