[Merged by Bors] - feat: add dsimp% elaborator#36043
Closed
robin-carlier wants to merge 10 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - feat: add dsimp% elaborator#36043robin-carlier wants to merge 10 commits intoleanprover-community:masterfrom
dsimp% elaborator#36043robin-carlier wants to merge 10 commits intoleanprover-community:masterfrom
Conversation
PR summary 32af1e5dd5
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Tactic.Common | 247 | 249 | +2 (+0.81%) |
| Mathlib.Tactic | 2972 | 2974 | +2 (+0.07%) |
Import changes for all files
| Files | Import difference |
|---|---|
| There are 6716 files with changed transitive imports taking up over 298525 characters: this is too many to display! | |
You can run ci-tools/scripts/pr_summary/import_trans_difference.sh all locally to see the whole output. |
Declarations diff
+ dsimpPercentElaborator
+ f
+ f_apply
+ g
+ g_apply
You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
JovanGerb
approved these changes
Mar 4, 2026
Contributor
|
Oh and maybe capitalize the |
Co-authored-by: Jovan Gerbscheid <[email protected]>
Co-authored-by: Jovan Gerbscheid <[email protected]>
Co-authored-by: Jovan Gerbscheid <[email protected]>
Contributor
|
You can import this in |
Contributor
|
Thanks! maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by JovanGerb. |
mathlib-triage
bot
added
the
maintainer-merge
Contributor
|
Thanks! bors merge |
mathlib-triage
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 5, 2026
This PR adds a `dsimp%` elaborators that puts a given term in `dsimp`-normal form. This is useful as a way to avoid the `have foo := …; dsimp at foo; rw [foo]` pattern. From [SymmMonCoherence](https://github.com/robin-carlier/SymmMonCoherence) Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
dsimp% elaboratordsimp% elaborator
seewoo5
pushed a commit
to seewoo5/mathlib4
that referenced
this pull request
Mar 9, 2026
This PR adds a `dsimp%` elaborators that puts a given term in `dsimp`-normal form. This is useful as a way to avoid the `have foo := …; dsimp at foo; rw [foo]` pattern. From [SymmMonCoherence](https://github.com/robin-carlier/SymmMonCoherence) Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
xroblot
pushed a commit
to xroblot/mathlib4
that referenced
this pull request
Mar 10, 2026
This PR adds a `dsimp%` elaborators that puts a given term in `dsimp`-normal form. This is useful as a way to avoid the `have foo := …; dsimp at foo; rw [foo]` pattern. From [SymmMonCoherence](https://github.com/robin-carlier/SymmMonCoherence) Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
dsimp%elaborators that puts a given term indsimp-normal form. This is useful as a way to avoid thehave foo := …; dsimp at foo; rw [foo]pattern.From SymmMonCoherence
The main possible extension for this (of which I would be grateful to have some level of help in doing) would be to also add a syntax forNow done, thanks a lot @JovanGerb !dsimp% […]dsimp