Skip to content

feat(SimpleGraph): redefine IsBridge via deleteEdges#36022

Closed
SproutSeeds wants to merge 1 commit intoleanprover-community:masterfrom
SproutSeeds:cody/issue-31690-bridges
Closed

feat(SimpleGraph): redefine IsBridge via deleteEdges#36022
SproutSeeds wants to merge 1 commit intoleanprover-community:masterfrom
SproutSeeds:cody/issue-31690-bridges

Conversation

@SproutSeeds
Copy link
Copy Markdown

@SproutSeeds SproutSeeds commented Mar 3, 2026

Closes #31690

Redefines SimpleGraph.IsBridge via deletion-only connectivity, without embedding edge membership into the definition.
Updates bridge definition and supporting lemmas.

Validation: targeted lake build and lake exe runLinter --trace passed for touched module(s).

Intelligent systems usage: tool=Codex; model=Codex 5.3; effort=extra high; workflow=ORP local-first gates (viability/overlap/naturality/targeted build+linter/draft CI); scope=drafting/refactoring/proof exploration including PR description drafting; final code choices and validation by me.

Happy to adjust naming, placement, or proof style based on maintainer preference.

- drop edge-membership requirement from IsBridge definition

- adapt bridge lemmas to take adjacency/membership assumptions explicitly

- update downstream proofs in EdgeConnectivity, Acyclic, Hamiltonian

- verification: lake build
@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Mar 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2026

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@SproutSeeds SproutSeeds changed the title feat(SimpleGraph): redefine via feat(SimpleGraph): redefine IsBridge via deleteEdges Mar 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2026

PR summary 6a736c34df

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ IsBridge.forall_cycle_notMem

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-combinatorics Combinatorics label Mar 3, 2026
@SproutSeeds SproutSeeds marked this pull request as ready for review March 3, 2026 10:54
@SproutSeeds
Copy link
Copy Markdown
Author

Marked this PR ready for review.

CI was green on the current branch when switching out of draft.

@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Mar 4, 2026

Hello from triage: your PR description shares features with many AI-written texts --- did you use AI to create this PR? If so, please mention that and how you used AI in your PR description. This helps us review your PR better. Thanks!

@grunweg grunweg added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 4, 2026
@kim-em kim-em closed this Mar 5, 2026
@grunweg grunweg added the LLM-generated PRs with substantial input from LLMs - review accordingly label Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author A reviewer has asked the author a question or requested changes. LLM-generated PRs with substantial input from LLMs - review accordingly new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-combinatorics Combinatorics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change bridges not to require the edge to be present

3 participants