Skip to content

[Merged by Bors] - feat(Algebra/ModuleCat): API on short complex in ModuleCat#35882

Closed
Thmoas-Guan wants to merge 2 commits intoleanprover-community:masterfrom
Thmoas-Guan:API-on-ShortComplex-in-ModuleCat
Closed

[Merged by Bors] - feat(Algebra/ModuleCat): API on short complex in ModuleCat#35882
Thmoas-Guan wants to merge 2 commits intoleanprover-community:masterfrom
Thmoas-Guan:API-on-ShortComplex-in-ModuleCat

Conversation

@Thmoas-Guan
Copy link
Copy Markdown
Collaborator

Adding some API on short complex in ModuleCat, for construction and exactness.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 28, 2026

PR summary fad8d3adce

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ ModuleCat.shortComplexOfCompEqZero
+ ModuleCat.shortComplex_exact
+ ModuleCat.shortComplex_shortExact

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Feb 28, 2026
@dagurtomas
Copy link
Copy Markdown
Contributor

You should add API for doing things like replacing terms of short exact sequences with isomorphic terms/equal submodules, etc. Then this will be more useful in #32058

@dagurtomas dagurtomas added awaiting-author A reviewer has asked the author a question or requested changes. awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. and removed awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Mar 5, 2026
@Thmoas-Guan
Copy link
Copy Markdown
Collaborator Author

Thmoas-Guan commented Mar 6, 2026

You should add API for doing things like replacing terms of short exact sequences with isomorphic terms/equal submodules, etc. Then this will be more useful in #32058

I disagree, this is a matter with Funtion.Exact for linear map, nothing to do with ModuleCat.
This PR already contain the ones do related to ModuleCat.

@Thmoas-Guan Thmoas-Guan removed the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 6, 2026
@dagurtomas
Copy link
Copy Markdown
Contributor

dagurtomas commented Mar 6, 2026

What do you mean? You can add all the general API that can be factored out from the long proof in #32058. You don't have to restrict yourself to ModuleCat. Of course, feel free to split the API additions into two PRs if you feel like there is a natural split.

@dagurtomas dagurtomas added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 6, 2026
@Thmoas-Guan
Copy link
Copy Markdown
Collaborator Author

I mean the inconvenience in #32058 is caused by two different things: 1: the things related with ModuleCat, which is already all in this PR, 2: the inconvenence of proving exactness for LinearMap, hopefully I'll soon open another PR for it.

@Thmoas-Guan Thmoas-Guan removed the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 6, 2026
@joelriou
Copy link
Copy Markdown
Contributor

joelriou commented Mar 6, 2026

Let us merge this now. Some additions may be useful in the future

bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Mar 6, 2026
mathlib-bors bot pushed a commit that referenced this pull request Mar 6, 2026
Adding some API on short complex in ModuleCat, for construction and exactness.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 6, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/ModuleCat): API on short complex in ModuleCat [Merged by Bors] - feat(Algebra/ModuleCat): API on short complex in ModuleCat Mar 6, 2026
@mathlib-bors mathlib-bors bot closed this Mar 6, 2026
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Mar 8, 2026
…r-community#35882)

Adding some API on short complex in ModuleCat, for construction and exactness.
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Mar 9, 2026
…r-community#35882)

Adding some API on short complex in ModuleCat, for construction and exactness.
seewoo5 pushed a commit to seewoo5/mathlib4 that referenced this pull request Mar 9, 2026
…r-community#35882)

Adding some API on short complex in ModuleCat, for construction and exactness.
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Mar 10, 2026
…r-community#35882)

Adding some API on short complex in ModuleCat, for construction and exactness.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants