feat(Order/Defs/LinearOrder): min_ind#35880
Open
astrainfinita wants to merge 2 commits intoleanprover-community:masterfrom
Open
feat(Order/Defs/LinearOrder): min_ind#35880astrainfinita wants to merge 2 commits intoleanprover-community:masterfrom
min_ind#35880astrainfinita wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
PR summary 6682a4e77fImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
2 tasks
| exacts [ha h, hb (le_of_not_ge h)] | ||
|
|
||
| @[to_dual existing (attr := elab_as_elim)] | ||
| theorem max_ind {motive : α → Prop} (ha : b ≤ a → motive a) (hb : a ≤ b → motive b) : |
Contributor
There was a problem hiding this comment.
If you move this after max_def' a few lines below, you should be able to get rid of the duplication (and the existing).
Collaborator
Author
There was a problem hiding this comment.
The subsequent PR will use other lemmas to simplify the proofs of min_def' and max_def', similar to #35841 (comment).
I don't have a strong preference. I'm fine with the suggestion if that's preferred.
bryangingechen
added
the
awaiting-author
astrainfinita
removed
the
awaiting-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It will be used to simplify the proofs of other lemmas in a subsequent PR.