feat: unit lemmas and embedding for FiniteAdeleRing#35820
Open
smmercuri wants to merge 10 commits intoleanprover-community:masterfrom
Open
feat: unit lemmas and embedding for FiniteAdeleRing#35820smmercuri wants to merge 10 commits intoleanprover-community:masterfrom
FiniteAdeleRing#35820smmercuri wants to merge 10 commits intoleanprover-community:masterfrom
Conversation
Collaborator
smmercuri
commented
Feb 26, 2026
smmercuri
commented
PR summary ffb5b8a658
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.RingTheory.DedekindDomain.FiniteAdeleRing | 2259 | 2261 | +2 (+0.09%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.NumberTheory.NumberField.AdeleRing |
1 |
Mathlib.RingTheory.DedekindDomain.FiniteAdeleRing |
2 |
Declarations diff
+ algebraMap_apply
+ infinite_valued_ne_one_of_not_isUnit
+ isUnit_iff
+ unitEmbedding
+ unitEmbedding_apply
+ unitsEquiv_finite_valued_eq_one
You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.
Increase in tech debt: (relative, absolute) = (1.00, 0.00)
| Current number | Change | Type |
|---|---|---|
| 6796 | 1 | backward.isDefEq.respectTransparency |
Current commit b5a1b1a1ef
Reference commit ffb5b8a658
You can run this locally as
./scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
1 task
Multramate
approved these changes
Mar 31, 2026
| variable {R K} | ||
|
|
||
| set_option backward.isDefEq.respectTransparency false in | ||
| theorem isUnit_iff {a : FiniteAdeleRing R K} : |
Collaborator
There was a problem hiding this comment.
Maybe:
Suggested change
| theorem isUnit_iff {a : FiniteAdeleRing R K} : | |
| theorem isUnit_iff (a : FiniteAdeleRing R K) : |
Collaborator
Author
There was a problem hiding this comment.
This is meant to be a rewrite lemma, so I think we want to keep a implicit?
Co-authored-by: Ruben Van de Velde <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.