[Merged by Bors] - chore: also try dsimp for proving continuity in the Homeomorph fields#35697
Closed
gasparattila wants to merge 2 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore: also try dsimp for proving continuity in the Homeomorph fields#35697gasparattila wants to merge 2 commits intoleanprover-community:masterfrom
dsimp for proving continuity in the Homeomorph fields#35697gasparattila wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
PR summary 0f8bcdff02Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
gasparattila
force-pushed
the
homeomorph-dsimp
branch
from
624db8e to
5444a04
Compare
mathlib-dependent-issues
bot
added
the
blocked-by-other-PR
mathlib-merge-conflicts
bot
added
the
merge-conflict
|
This pull request has conflicts, please merge |
gasparattila
force-pushed
the
homeomorph-dsimp
branch
from
6133283 to
7fef0cb
Compare
github-actions
bot
removed
the
merge-conflict
gasparattila
force-pushed
the
homeomorph-dsimp
branch
from
7fef0cb to
c8162b3
Compare
mathlib-dependent-issues
bot
removed
the
blocked-by-other-PR
|
This PR/issue depends on:
|
Contributor
|
!bench |
Contributor
|
The main reason I didn't do so was performance; let's check the impact of this change. |
|
Benchmark results for c8162b3 against 0f8bcdf are in. There are no significant changes. @grunweg
No significant changes detected. |
grunweg
changed the title
dsimp in the default tactics of Homeomorph fieldsdsimp for proving continuity in the Homeomorph fields
Contributor
|
Thanks! |
Contributor
|
bors r+ |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
dsimp for proving continuity in the Homeomorph fieldsdsimp for proving continuity in the Homeomorph fields
xroblot
pushed a commit
to xroblot/mathlib4
that referenced
this pull request
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will also reduce the breakage in #35548.
eta_expandidempotent #35607