You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR changes fun_prop to detect some theorems involving dependent types, such as Continous.subtype_mk to be in compositional form. This lets fun_prop solve goals such as Continuous fun x => (⟨x, trivial⟩ : {x : ℝ // True}).
These theorems become compositional: Continuous.subtype_mk, Topology.IsEmbedding.inclusion, Topology.IsOpenEmbedding.inclusion, Topology.IsClosedEmbedding.inclusion, Measurable.subtype_mk, Measurable.imp, Path.symm_continuous_family, Continuous.upperHalfPlaneMk
These theorems become simple: hasFDerivAt_prodMk_left, hasFDerivAt_prodMk_right, contDiff_prodMk_left, contDiff_prodMk_right
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>
The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.
The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
I've checked the uses of Continuous.subtype_mk, but it turned out that none of them were affected by this bug (other than the one in #35697). The reason is that if both the theorem and the goal have dependent types, then the decomposition fails in both cases, so fun_prop applies the theorem directly, which has the same effect as if it was compositional. So this bug appears only when the goal is less dependent than the theorem, such as in the test cases in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gasparattila
force-pushed
the
fun_prop-subtype-fix
branch
from
mathlib-merge-conflicts
bot
added
the
merge-conflict
github-actions
bot
removed
the
merge-conflict
This PR changes
fun_propto detect some theorems involving dependent types, such asContinous.subtype_mkto be in compositional form. This letsfun_propsolve goals such asContinuous fun x => (⟨x, trivial⟩ : {x : ℝ // True}).These theorems become compositional:
Continuous.subtype_mk,Topology.IsEmbedding.inclusion,Topology.IsOpenEmbedding.inclusion,Topology.IsClosedEmbedding.inclusion,Measurable.subtype_mk,Measurable.imp,Path.symm_continuous_family,Continuous.upperHalfPlaneMkThese theorems become simple:
hasFDerivAt_prodMk_left,hasFDerivAt_prodMk_right,contDiff_prodMk_left,contDiff_prodMk_right