Skip to content

feat(Cache): Allow arguments of the form Mathlib.Data.+ which correspond to a folder but not a file#35414

Open
joneugster wants to merge 2 commits intoleanprover-community:masterfrom
joneugster:eugster/cache_pseudo_module_args
Open

feat(Cache): Allow arguments of the form Mathlib.Data.+ which correspond to a folder but not a file#35414
joneugster wants to merge 2 commits intoleanprover-community:masterfrom
joneugster:eugster/cache_pseudo_module_args

Conversation

@joneugster
Copy link
Copy Markdown
Contributor

This PR continues the work from #21838.

Original PR: #21838

@joneugster
Copy link
Copy Markdown
Contributor Author

Comments from Original PR #21838

This section contains 3 comment(s) from the original PR, excluding bot comments.


@mergify (2025-02-13 17:59 UTC):
⚠️ The sha of the head commit of this PR conflicts with #21834. Mergify cannot evaluate rules on this PR. ⚠️


@joneugster (2025-03-05 09:58 UTC):
Note to myself: check if something like the following is needed:

  -- TODO: This could be `(argₛ : FilePath).normalize` if the comment there got addressed
  -- (which says "TODO: normalize `a/`, `a//b`, etc.")
  let arg : FilePath := System.mkFilePath <| (argₛ : FilePath).components.filter (· != "")

@joneugster (2025-04-04 14:01 UTC):
I've tested this with two lake new CacheTest math.lean, one setting mathlib to this branch, one setting it to a local copy at ../../mathlib4. In both cases lake exe cache get Mathlib.Data seemed to work just fine.

@github-actions
Copy link
Copy Markdown

PR summary 88bb6d226a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@joneugster joneugster added t-meta Tactics, attributes or user commands CI Modifies the continuous integration setup or other automation labels Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Modifies the continuous integration setup or other automation t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants