feat(SimpleGraph): redefine cycleGraph independent of circulantGraph#35250
Open
vlad902 wants to merge 3 commits intoleanprover-community:masterfrom
Open
feat(SimpleGraph): redefine cycleGraph independent of circulantGraph#35250vlad902 wants to merge 3 commits intoleanprover-community:masterfrom
cycleGraph independent of circulantGraph#35250vlad902 wants to merge 3 commits intoleanprover-community:masterfrom
Conversation
vlad902
changed the title
cycleGraph independent of circulanGraphcycleGraph independent of circulantGraph
PR summary 81b174f9deImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
SnirBroshi
approved these changes
Feb 13, 2026
Right now the `cycleGraph` definition relies on `circulantGraph` which requires importing Group definitions from the algebra hierarchy. This causes large-imports for me in later PRs where I try to make more widespread use of cycleGraphs, so here I redefine it to be its own independent object, and leave splitting it from `circulantGraph` to another PR (this is parallel to leanprover-community#35084.)
vlad902
force-pushed
the
redef-cycle-graph
branch
from
e0c3a44 to
249a7fe
Compare
vihdzp
approved these changes
Feb 13, 2026
Collaborator
vihdzp
left a comment
vihdzp
left a comment
There was a problem hiding this comment.
Otherwise LGTM, I'm glad this is a simple change!
Co-authored-by: Violeta Hernández Palacios <[email protected]>
YaelDillies
approved these changes
Mar 24, 2026
Contributor
YaelDillies
left a comment
YaelDillies
left a comment
There was a problem hiding this comment.
Looks good, but is @Bhavik Mehta happy with it?
maintainer merge?
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
mathlib-triage
bot
added
the
maintainer-merge
b-mehta
reviewed
Apr 3, 2026
Contributor
b-mehta
left a comment
b-mehta
left a comment
There was a problem hiding this comment.
I did like the definition of cycleGraph in terms of circulantGraph, but I accept the motivation here. Can we keep the equality cycleGraph (n + 1) = circulantGraph {1} as a lemma though (even if it's not defeq any more)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the
cycleGraphdefinition relies oncirculantGraphwhich requires importing Group definitions from the algebra hierarchy. This causes large-imports for me in later PRs where I try to make more widespread use of cycleGraphs, so here I redefine it to be its own independent object, and leave moving it fromCirculant.leanto another PR (this is parallel to #35084.)