feat(SimpleGraph): cycleGraph.cycle is a cycle#34797
Open
vlad902 wants to merge 2 commits intoleanprover-community:masterfrom
Open
feat(SimpleGraph): cycleGraph.cycle is a cycle#34797vlad902 wants to merge 2 commits intoleanprover-community:masterfrom
cycleGraph.cycle is a cycle#34797vlad902 wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
vlad902
changed the title
cycleGraph is a cycle and IsContained in every graph with a cyclecycleGraph is a cycle and IsContained in every graph with a cycle
PR summary db6ec05280Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
mathlib-dependent-issues
bot
added
the
blocked-by-other-PR
2 tasks
vlad902
commented
Feb 3, 2026
vlad902
commented
Feb 6, 2026
mathlib-dependent-issues
bot
removed
the
blocked-by-other-PR
vlad902
force-pushed
the
cycleGraph-eulerianCircuit
branch
from
e3a8af9 to
a04966e
Compare
vlad902
changed the title
cycleGraph is a cycle and IsContained in every graph with a cyclecycleGraph is a cycle
vlad902
changed the title
cycleGraph is a cyclecycleGraph_EulerianCircuit is a cycle
Ruben-VandeVelde
added
the
awaiting-author
vlad902
added a commit
to vlad902/mathlib4
that referenced
this pull request
Feb 15, 2026
….cycle` Per [this](leanprover-community#34797 (comment)) review feedback, this definition is inappropriately named with an underscore and should be renamed.
vlad902
removed
the
awaiting-author
mathlib-dependent-issues
bot
added
the
blocked-by-other-PR
vlad902
added a commit
to vlad902/mathlib4
that referenced
this pull request
Mar 14, 2026
….cycle` Per [this](leanprover-community#34797 (comment)) review feedback, this definition is inappropriately named with an underscore and should be renamed.
vlad902
force-pushed
the
cycleGraph-eulerianCircuit
branch
from
c9a756e to
21f85c3
Compare
vlad902
changed the title
cycleGraph_EulerianCircuit is a cyclecycleGraph.cycle is a cycle
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 19, 2026
) Per [this](#34797 (comment)) review feedback, this definition is inappropriately named with an underscore and should be renamed.
(A follow-up PR will show that `cycleGraph.cycle` is also hamiltonian.)
vlad902
force-pushed
the
cycleGraph-eulerianCircuit
branch
from
21f85c3 to
1ae94a7
Compare
mathlib-dependent-issues
bot
removed
the
blocked-by-other-PR
justus-springer
pushed a commit
to justus-springer/mathlib4
that referenced
this pull request
Mar 28, 2026
…nprover-community#35360) Per [this](leanprover-community#34797 (comment)) review feedback, this definition is inappropriately named with an underscore and should be renamed.
vlad902
added a commit
to vlad902/mathlib4
that referenced
this pull request
Apr 11, 2026
PR leanprover-community#34797 re-defined `cycleGraph` independent of `circulantGraph`. Now move the definition of `cycleGraph` to its own file so that the definition can be used without importing the algebra hierarchy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(A follow-up PR will show that
cycleGraph.cycleis also hamiltonian.)cycleGraph_EulerianCircuittocycleGraph.cycle#35360