Skip to content

feat(RingTheory/MvPolynomial/MonomialOrder): add degree with as degree of 0#34759

Open
Hagb wants to merge 25 commits intoleanprover-community:masterfrom
WuProver:withBotDegree
Open

feat(RingTheory/MvPolynomial/MonomialOrder): add degree with as degree of 0#34759
Hagb wants to merge 25 commits intoleanprover-community:masterfrom
WuProver:withBotDegree

Conversation

@Hagb
Copy link
Copy Markdown
Collaborator

@Hagb Hagb commented Feb 3, 2026

withBotDegree is to distinguish the degree of zero polynomial from the degree of non-zero constant polynomial. MonomialOrder.degree of both are 0, while withBotDegree is for zero polynomial and 0 for non-zero constant polynomial.

MonomialOrder.withBotDegree is to MonomialOrder.degree as Polynomial.degree is to Polynomial.natDegree.

It's upstreamized from https://github.com/WuProver/groebner_proj.


It's upstream from Groebner/MonomialOrder.lean in the repo WuProver/groebner_proj.

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 3, 2026

PR summary d7385d0300

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Data.Finsupp.MonomialOrder 823 824 +1 (+0.12%)
Import changes for all files
Files Import difference
Mathlib.Data.Finsupp.MonomialOrder 1

Declarations diff

+ bot_lt_toWithBotSyn_apply_iff
+ degree_eq_unbotD_withBotDegree
+ le_withBotDegree
+ toWithBotSyn
+ toWithBotSyn_apply
+ toWithBotSyn_apply_bot
+ toWithBotSyn_apply_coe
+ toWithBotSyn_apply_eq_bot_iff
+ toWithBotSyn_apply_le_bot_iff
+ toWithBotSyn_symm_apply_bot
+ toWithBotSyn_symm_apply_eq_bot
+ toWithBotSyn_withBotDegree_mul_le
+ withBotDegree
+ withBotDegree_C
+ withBotDegree_add_le
+ withBotDegree_add_of_lt
+ withBotDegree_add_of_right_lt
+ withBotDegree_eq
+ withBotDegree_eq_bot_iff
+ withBotDegree_eq_coe_degree_iff
+ withBotDegree_eq_withBotDegree_iff
+ withBotDegree_le_withBotDegree_iff
+ withBotDegree_le_withBotDegree_iff_of_ne_zero
+ withBotDegree_le_withBotDegree_of_support_subset
+ withBotDegree_leadingTerm
+ withBotDegree_lt_withBotDegree_iff
+ withBotDegree_lt_withBotDegree_iff_of_ne_zero
+ withBotDegree_monomial
+ withBotDegree_mul
+ withBotDegree_mul_le
+ withBotDegree_mul_of_left_mem_nonZeroDivisors
+ withBotDegree_mul_of_right_mem_nonZeroDivisors
+ withBotDegree_neg
+ withBotDegree_one
+ withBotDegree_sum_le
+ withBotDegree_zero

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 3, 2026

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@Hagb Hagb changed the title feat(RingTheory/MvPolynomial/MonomialOrder): add degree with ⊥ as degree of 0 feat(RingTheory/MvPolynomial/MonomialOrder): add degree with as degree of 0 Feb 3, 2026
@Hagb Hagb changed the title feat(RingTheory/MvPolynomial/MonomialOrder): add degree with as degree of 0 feat(RingTheory/MvPolynomial/MonomialOrder): add degree with as degree of 0 Feb 3, 2026
@Hagb Hagb changed the title feat(RingTheory/MvPolynomial/MonomialOrder): add degree with as degree of 0 feat(RingTheory/MvPolynomial/MonomialOrder): add degree with as degree of 0 Feb 3, 2026
@Hagb Hagb changed the title feat(RingTheory/MvPolynomial/MonomialOrder): add degree with as degree of 0 feat(RingTheory/MvPolynomial/MonomialOrder): add degree with as degree of 0 Feb 3, 2026
@mathlib-dependent-issues mathlib-dependent-issues bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 3, 2026
@joneugster
Copy link
Copy Markdown
Contributor

you can now comment on the PR to add missing topic labels:

t-ring-theory

(improvements to the automation are on the way: #34078)

@github-actions github-actions bot added the t-ring-theory Ring theory label Feb 7, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@mathlib-merge-conflicts mathlib-merge-conflicts bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 24, 2026
mathlib-bors bot pushed a commit that referenced this pull request Apr 3, 2026
…hBot` (#34756)

It is like `Equiv.withBotCongr` but preserving also addition (`AddEquiv`), for a variant of degree of `MvPolynomial` that maps `0` to `⊥` submitted in #34759.
@mathlib-dependent-issues mathlib-dependent-issues bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 3, 2026
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Apr 3, 2026
…hBot` (leanprover-community#34756)

It is like `Equiv.withBotCongr` but preserving also addition (`AddEquiv`), for a variant of degree of `MvPolynomial` that maps `0` to `⊥` submitted in leanprover-community#34759.
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 3, 2026
@mathlib-dependent-issues
Copy link
Copy Markdown

riccardobrasca pushed a commit to riccardobrasca/mathlib4 that referenced this pull request Apr 6, 2026
…hBot` (leanprover-community#34756)

It is like `Equiv.withBotCongr` but preserving also addition (`AddEquiv`), for a variant of degree of `MvPolynomial` that maps `0` to `⊥` submitted in leanprover-community#34759.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants