feat(RingTheory): Grassmannian functor#34705
Open
mpenciak wants to merge 14 commits intoleanprover-community:masterfrom
Open
feat(RingTheory): Grassmannian functor#34705mpenciak wants to merge 14 commits intoleanprover-community:masterfrom
mpenciak wants to merge 14 commits intoleanprover-community:masterfrom
Conversation
PR summary c71d2faa1bImport changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.LinearAlgebra.TensorProduct.Quotient | 1127 | 1164 | +37 (+3.28%) |
| Mathlib.RingTheory.Grassmannian | 2114 | 2130 | +16 (+0.76%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.RingTheory.Finiteness.NilpotentKer |
1 |
Mathlib.RingTheory.Grassmannian |
16 |
Mathlib.LinearAlgebra.TensorProduct.Quotient |
37 |
Declarations diff
+ baseChange_comp_cancelBaseChange_symm_self
+ baseChange_mkQ_surjective
+ cancelBaseChange_self_eq_lid
+ functor
+ ker_baseChange_comp_cancelBaseChange_symm
+ map
+ map_comp
+ map_id
You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
robin-carlier
added
the
awaiting-author
Collaborator
Author
|
Thanks for the review! I think I addressed your comments, incorporated your changes, and cleaned up the Claude's first pass of the proofs so they should be more clear now. |
mpenciak
removed
awaiting-author
mathlib-merge-conflicts
bot
added
the
merge-conflict
|
This pull request has conflicts, please merge |
github-actions
bot
removed
the
merge-conflict
grunweg
added
the
LLM-generated
chrisflav
reviewed
Mar 21, 2026
chrisflav
added
the
awaiting-author
chrisflav
changed the title
mpenciak
removed
the
awaiting-author
chrisflav
reviewed
Apr 1, 2026
chrisflav
added
the
awaiting-author
github-actions
bot
added
the
large-import
mpenciak
force-pushed
the
grassmannian
branch
3 times, most recently
from
efe2b89 to
9b6bfa2
Compare
Collaborator
Author
|
I think I fixed up your comments, let me know how it looks!
|
mpenciak
removed
the
awaiting-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR shows that the association
A → G(k, (A ⊗[R] M); A)for anR-algebraAandR-moduleMforms a functor.(AI disclosure: an early version of this PR was prepared with the help of Claude)