Skip to content

[Merged by Bors] - chore(Archive): small golfs#34688

Closed
grunweg wants to merge 1 commit intoleanprover-community:masterfrom
grunweg:archivegolf
Closed

[Merged by Bors] - chore(Archive): small golfs#34688
grunweg wants to merge 1 commit intoleanprover-community:masterfrom
grunweg:archivegolf

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Feb 1, 2026

Use fun_prop more, and make indentation match mathlib style better. Extracted from #31607.


Open in Gitpod

Use fun_prop more, and make indentation match mathlib style better.
Extracted from leanprover-community#31607.
@grunweg grunweg requested a review from YaelDillies February 1, 2026 16:22
@grunweg grunweg added easy < 20s of review time. See the lifecycle page for guidelines. and removed easy < 20s of review time. See the lifecycle page for guidelines. labels Feb 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 1, 2026

PR summary e3128c5dc9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 1, 2026

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Feb 1, 2026
@vihdzp
Copy link
Copy Markdown
Collaborator

vihdzp commented Feb 1, 2026

I don't think there's anything in Counterexamples here? can you update the title?

@grunweg grunweg changed the title chore(Archive,Counterexamples): small golfs chore(Archive): small golfs Feb 1, 2026
IntervalIntegrable (fun (θ : ℝ) => min d (θ.sin * l)) ℙ a b := by
apply Continuous.intervalIntegrable
exact Continuous.min continuous_const (Continuous.mul Real.continuous_sin continuous_const)
apply Continuous.intervalIntegrable (by fun_prop)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we ought to make IntervalIntegrable work with fun_prop too...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in the tracking issue now (sorry can't find it right now)

Copy link
Copy Markdown
Contributor

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Feb 1, 2026
mathlib-bors bot pushed a commit that referenced this pull request Feb 1, 2026
Use fun_prop more, and make indentation match mathlib style better. Extracted from #31607.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 1, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Archive): small golfs [Merged by Bors] - chore(Archive): small golfs Feb 1, 2026
@mathlib-bors mathlib-bors bot closed this Feb 1, 2026
YellPika pushed a commit to YellPika/mathlib4 that referenced this pull request Feb 3, 2026
Use fun_prop more, and make indentation match mathlib style better. Extracted from leanprover-community#31607.
michaellee94 pushed a commit to michaellee94/mathlib4 that referenced this pull request Feb 15, 2026
Use fun_prop more, and make indentation match mathlib style better. Extracted from leanprover-community#31607.
Maldooor pushed a commit to Maldooor/mathlib4 that referenced this pull request Feb 25, 2026
Use fun_prop more, and make indentation match mathlib style better. Extracted from leanprover-community#31607.
@grunweg grunweg deleted the archivegolf branch February 28, 2026 15:56
pfaffelh pushed a commit to pfaffelh/mathlib4 that referenced this pull request Mar 2, 2026
Use fun_prop more, and make indentation match mathlib style better. Extracted from leanprover-community#31607.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants