refactor(Order): make CompletePartialOrder extend OrderBot#34477
Open
spanning-tree wants to merge 3 commits intoleanprover-community:masterfrom
Open
refactor(Order): make CompletePartialOrder extend OrderBot#34477spanning-tree wants to merge 3 commits intoleanprover-community:masterfrom
spanning-tree wants to merge 3 commits intoleanprover-community:masterfrom
Conversation
github-actions
bot
added
the
new-contributor
PR summary 72b9c8db26Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
spanning-tree
force-pushed
the
CPO
branch
2 times, most recently
from
cb98a61 to
1e4311a
Compare
Make `CompletePartialOrder` extend `OrderBot`, and add a constructor `completePartialOrderOfLubOfDirected`. Previously, `CompletePartialOrder` had an implicit bottom element but did not extend OrderBot explicitly. Breaking change: `CompletePartialOrder` instances must provide `⊥` and `bot_le`, or use the constructor.
Co-authored-by: Citronhat <[email protected]>
|
This pull request has conflicts, please merge |
mathlib-merge-conflicts
bot
added
the
merge-conflict
github-actions
bot
removed
the
merge-conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
CompletePartialOrderextendOrderBot, and add a constructorcompletePartialOrderOfLubOfDirected. Previously,CompletePartialOrderhad an implicit bottom element but did not extend OrderBot explicitly.Breaking change:
CompletePartialOrderinstances must provide⊥andbot_le, or use the constructor.See discussion in Zulip.