Skip to content

feat(Topology/Sets): topological properties of (Nonempty)Compacts.map#34275

Open
gasparattila wants to merge 2 commits intoleanprover-community:masterfrom
gasparattila:compacts-map-continuous
Open

feat(Topology/Sets): topological properties of (Nonempty)Compacts.map#34275
gasparattila wants to merge 2 commits intoleanprover-community:masterfrom
gasparattila:compacts-map-continuous

Conversation

@gasparattila
Copy link
Copy Markdown
Contributor

@gasparattila gasparattila commented Jan 22, 2026 •
edited
Loading

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Jan 22, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 22, 2026 •
edited
Loading

PR summary 4e83c73533

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ _root_.Continuous.compacts_map
+ _root_.Continuous.image_vietoris
+ _root_.Continuous.nonemptyCompacts_map
+ _root_.Topology.IsClosedEmbedding.compacts_map
+ _root_.Topology.IsClosedEmbedding.nonemptyCompacts_map
+ _root_.Topology.IsEmbedding.compacts_map
+ _root_.Topology.IsEmbedding.image_vietoris
+ _root_.Topology.IsEmbedding.nonemptyCompacts_map
+ _root_.Topology.IsInducing.compacts_map
+ _root_.Topology.IsInducing.image_vietoris
+ _root_.Topology.IsInducing.nonemptyCompacts_map
+ _root_.Topology.IsOpenEmbedding.compacts_map
+ _root_.Topology.IsOpenEmbedding.nonemptyCompacts_map

You can run this locally as follows 
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jan 22, 2026
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 28, 2026
@mathlib4-merge-conflict-bot
Copy link
Copy Markdown
Collaborator

mathlib4-merge-conflict-bot commented Jan 28, 2026

This pull request has conflicts, please merge master and resolve them.

@gasparattila gasparattila force-pushed the compacts-map-continuous branch from 9210077 to 3abcd5a Compare January 28, 2026 14:17
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 28, 2026
@mathlib-merge-conflicts mathlib-merge-conflicts bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 23, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

mathlib-merge-conflicts bot commented Mar 23, 2026

This pull request has conflicts, please merge master and resolve them.

@gasparattila gasparattila force-pushed the compacts-map-continuous branch from 3abcd5a to 3593153 Compare April 1, 2026 13:31
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 1, 2026
@mathlib-dependent-issues mathlib-dependent-issues bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 1, 2026
@mathlib-dependent-issues
Copy link
Copy Markdown

mathlib-dependent-issues bot commented Apr 1, 2026

This PR/issue depends on:

scholzhannah
scholzhannah reviewed Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@scholzhannah scholzhannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! I have some minor comments on style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@scholzhannah scholzhannah scholzhannah left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@j-loreaux j-loreaux

Labels

t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gasparattila @mathlib4-merge-conflict-bot @scholzhannah @j-loreaux @mathlib4-dependent-issues-bot