feat(Topology/Sets): finite sets are dense in (Nonempty)Compacts#34273
Open
gasparattila wants to merge 2 commits intoleanprover-community:masterfrom
Open
feat(Topology/Sets): finite sets are dense in (Nonempty)Compacts#34273gasparattila wants to merge 2 commits intoleanprover-community:masterfrom
(Nonempty)Compacts#34273gasparattila wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
github-actions
bot
added
the
t-topology
PR summary 4e83c73533Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
mathlib4-dependent-issues-bot
added
the
blocked-by-other-PR
2 tasks
mathlib4-merge-conflict-bot
added
the
merge-conflict
Collaborator
|
This pull request has conflicts, please merge |
gasparattila
force-pushed
the
compacts-dense-finite
branch
from
42f25e5 to
5231420
Compare
github-actions
bot
removed
the
merge-conflict
gasparattila
force-pushed
the
compacts-dense-finite
branch
from
5231420 to
63df253
Compare
mathlib-dependent-issues
bot
removed
the
blocked-by-other-PR
|
This PR/issue depends on:
|
gasparattila
force-pushed
the
compacts-dense-finite
branch
from
63df253 to
0416cee
Compare
scholzhannah
reviewed
Apr 1, 2026
Collaborator
scholzhannah
left a comment
scholzhannah
left a comment
There was a problem hiding this comment.
Thank you for your PR! I have one small style comment.
scholzhannah
approved these changes
Apr 1, 2026
Co-authored-by: Hannah Scholz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Nonempty)Compacts#34266