feat(Combinatorics/Schnirelmann): if sum of densities is at least one, the sumset covers the naturals#34227
Open
stepan2698-cpu wants to merge 14 commits intoleanprover-community:masterfrom
Open
Conversation
github-actions
bot
added
new-contributor
PR summary 6ef8cc2731
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Combinatorics.Schnirelmann | 800 | 802 | +2 (+0.25%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Combinatorics.Schnirelmann |
2 |
Declarations diff
+ zero_union_add_eq_univ_of_schirelmannDensity_ge_one
+ zero_union_add_eq_univ_of_schirelmannDensity_ge_one_of_zero_mem
You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
grunweg
reviewed
Jan 21, 2026
kbuzzard
reviewed
Jan 22, 2026
Co-authored-by: Kevin Buzzard <[email protected]>
FLDutchmann
approved these changes
Mar 31, 2026
Collaborator
FLDutchmann
left a comment
FLDutchmann
left a comment
There was a problem hiding this comment.
Thanks! I've left a couple of style comments, but otherwise the proof looks good to me.
FLDutchmann
approved these changes
Mar 31, 2026
Collaborator
FLDutchmann
left a comment
FLDutchmann
left a comment
There was a problem hiding this comment.
Thanks! I've left a couple of style comments, but otherwise the proof looks good to me.
Collaborator
|
cc @YaelDillies |
YaelDillies
reviewed
Mar 31, 2026
YaelDillies
changed the title
YaelDillies
changed the title
Contributor
Author
|
-awaiting-author |
Co-authored-by: Yan Yablonovskiy <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proves an outstanding TODO item from Mathlib.Combinatorics.Schnirelmann : shows that if the sum of two densities is at least one, the sumset covers the positive naturals.