Skip to content

[Merged by Bors] - feat(CategoryTheory/ComposableArrows): isIso_iff#33879

Closed
joelriou wants to merge 2 commits intoleanprover-community:masterfrom
joelriou:spectral-sequences-3-composable-arrows-two
Closed

[Merged by Bors] - feat(CategoryTheory/ComposableArrows): isIso_iff#33879
joelriou wants to merge 2 commits intoleanprover-community:masterfrom
joelriou:spectral-sequences-3-composable-arrows-two

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented Jan 12, 2026 •
edited
Loading

We introduce lemmas characterizing isomorphisms in ComposableArrows C n for small numbers n. We add autoparams (by cat_disch) for certain parameters. We also make definitions like mk₂ abbreviations (instead of using the simp attribute), as it will allow to have mk₂ in the LHS/RHS of simp lemmas in the formalization of spectral sequences #33842.

Open in Gitpod

@joelriou joelriou added the t-category-theory Category theory label Jan 12, 2026
@joelriou joelriou mentioned this pull request Jan 12, 2026
Closed
43 tasks
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 12, 2026 •
edited
Loading

PR summary 23a3f86b32

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ homMk₂_app_two'
+ instance [IsIso f] : IsIso (twoδ₁Toδ₀ f g fg h) := by
+ instance [IsIso g] : IsIso (twoδ₂Toδ₁ f g fg h) := by
+ isIso_iff₀
+ isIso_iff₁
+ isIso_iff₂
+ twoδ₁Toδ₀'
+ twoδ₂Toδ₁'

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

This was referenced Jan 12, 2026
Closed
Closed
chrisflav
chrisflav reviewed Jan 16, 2026
View reviewed changes
Comment thread Mathlib/CategoryTheory/ComposableArrows/Basic.lean
Comment thread Mathlib/CategoryTheory/ComposableArrows/Basic.lean Outdated
@chrisflav chrisflav added the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 16, 2026
@joelriou joelriou removed the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 16, 2026
@chrisflav
Copy link
Copy Markdown
Member

chrisflav commented Jan 16, 2026

Thanks!
maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 16, 2026

🚀 Pull request has been placed on the maintainer queue by chrisflav.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jan 16, 2026
jcommelin
jcommelin reviewed Jan 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jan 17, 2026
@joelriou
feat(CategoryTheory/ComposableArrows): isIso_iff (#33879)
2cdef43 
We introduce lemmas characterizing isomorphisms in `ComposableArrows C n` for small numbers `n`. We add autoparams (`by cat_disch`) for certain parameters. We also make definitions like `mk₂` abbreviations (instead of using the `simp` attribute), as it will allow to have `mk₂` in the LHS/RHS of simp lemmas in the formalization of spectral sequences #33842.
@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jan 17, 2026
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 17, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CategoryTheory/ComposableArrows): isIso_iff [Merged by Bors] - feat(CategoryTheory/ComposableArrows): isIso_iff Jan 17, 2026
@mathlib-bors mathlib-bors bot closed this Jan 17, 2026
@github-actions github-actions bot mentioned this pull request Jan 18, 2026
Open
eliasjudin pushed a commit to eliasjudin/mathlib4 that referenced this pull request Jan 18, 2026
@joelriou @eliasjudin
feat(CategoryTheory/ComposableArrows): isIso_iff (leanprover-communit…
38385cd 
…y#33879)

We introduce lemmas characterizing isomorphisms in `ComposableArrows C n` for small numbers `n`. We add autoparams (`by cat_disch`) for certain parameters. We also make definitions like `mk₂` abbreviations (instead of using the `simp` attribute), as it will allow to have `mk₂` in the LHS/RHS of simp lemmas in the formalization of spectral sequences leanprover-community#33842.
bilichboris pushed a commit to bilichboris/mathlib4 that referenced this pull request Jan 18, 2026
@joelriou @bilichboris
feat(CategoryTheory/ComposableArrows): isIso_iff (leanprover-communit…
29ba217 
…y#33879)

We introduce lemmas characterizing isomorphisms in `ComposableArrows C n` for small numbers `n`. We add autoparams (`by cat_disch`) for certain parameters. We also make definitions like `mk₂` abbreviations (instead of using the `simp` attribute), as it will allow to have `mk₂` in the LHS/RHS of simp lemmas in the formalization of spectral sequences leanprover-community#33842.
staroperator pushed a commit to staroperator/mathlib4 that referenced this pull request Jan 22, 2026
@joelriou @staroperator
feat(CategoryTheory/ComposableArrows): isIso_iff (leanprover-communit…
443b457 
…y#33879)

We introduce lemmas characterizing isomorphisms in `ComposableArrows C n` for small numbers `n`. We add autoparams (`by cat_disch`) for certain parameters. We also make definitions like `mk₂` abbreviations (instead of using the `simp` attribute), as it will allow to have `mk₂` in the LHS/RHS of simp lemmas in the formalization of spectral sequences leanprover-community#33842.
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
@joelriou @goliath-klein
feat(CategoryTheory/ComposableArrows): isIso_iff (leanprover-communit…
fa9b9af 
…y#33879)

We introduce lemmas characterizing isomorphisms in `ComposableArrows C n` for small numbers `n`. We add autoparams (`by cat_disch`) for certain parameters. We also make definitions like `mk₂` abbreviations (instead of using the `simp` attribute), as it will allow to have `mk₂` in the LHS/RHS of simp lemmas in the formalization of spectral sequences leanprover-community#33842.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcommelin jcommelin jcommelin left review comments

@chrisflav chrisflav chrisflav left review comments

Assignees

No one assigned

Labels

ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joelriou @chrisflav @jcommelin