Skip to content

[Merged by Bors] - feat(ValuationSubring): fieldTop#33612

Closed
xgenereux wants to merge 5 commits intoleanprover-community:masterfrom
xgenereux:ValuationSubring.topField
Closed

[Merged by Bors] - feat(ValuationSubring): fieldTop#33612
xgenereux wants to merge 5 commits intoleanprover-community:masterfrom
xgenereux:ValuationSubring.topField

Conversation

@xgenereux
Copy link
Copy Markdown
Collaborator

@xgenereux xgenereux commented Jan 5, 2026 •
edited by jcommelin
Loading

Given a field K, the top element of ValuationSubring K is K, so top is also a field.

Note: I fear this would be a bad instance so I have marked this as an abbrev for now.

Open in Gitpod

@github-actions github-actions bot added the t-ring-theory Ring theory label Jan 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 5, 2026 •
edited
Loading

PR summary 6071796fef

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance : Field (⊤ : ValuationSubring K) := inferInstanceAs (Field (⊤ : Subfield K))
+ top_coe_div
+ top_coe_inv

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@xgenereux xgenereux mentioned this pull request Jan 5, 2026
Closed
2 tasks
vihdzp
vihdzp reviewed Jan 5, 2026
View reviewed changes
Comment thread Mathlib/RingTheory/Valuation/ValuationSubring.lean Outdated
vihdzp
vihdzp reviewed Jan 5, 2026
View reviewed changes
Comment thread Mathlib/RingTheory/Valuation/ValuationSubring.lean Outdated
vihdzp
vihdzp approved these changes Jan 5, 2026
View reviewed changes
Comment thread Mathlib/RingTheory/Valuation/ValuationSubring.lean Outdated
This was referenced Jan 5, 2026
Closed
Closed
erdOne
erdOne reviewed Jan 10, 2026
View reviewed changes
Comment thread Mathlib/RingTheory/Valuation/ValuationSubring.lean Outdated
@erdOne erdOne added the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 10, 2026
@xgenereux xgenereux removed the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 10, 2026
erdOne
erdOne reviewed Jan 17, 2026
View reviewed changes
Comment thread Mathlib/RingTheory/Valuation/ValuationSubring.lean
@erdOne erdOne added the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 17, 2026
@xgenereux xgenereux removed the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 19, 2026
@erdOne
Copy link
Copy Markdown
Member

erdOne commented Jan 20, 2026

Thanks!
maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 20, 2026

🚀 Pull request has been placed on the maintainer queue by erdOne.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jan 20, 2026
@jcommelin
Copy link
Copy Markdown
Member

jcommelin commented Jan 21, 2026

Thanks 🎉

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jan 21, 2026
mathlib-bors bot pushed a commit that referenced this pull request Jan 21, 2026
@xgenereux
feat(ValuationSubring): fieldTop (#33612)
2e4c6cf 
Given a field `K`, the top element of `ValuationSubring K` is `K`, so top is also a field.

Co-authored-by: Xavier Genereux <[email protected]>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 21, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(ValuationSubring): fieldTop [Merged by Bors] - feat(ValuationSubring): fieldTop Jan 21, 2026
@mathlib-bors mathlib-bors bot closed this Jan 21, 2026
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
@xgenereux @goliath-klein
feat(ValuationSubring): fieldTop (leanprover-community#33612)
140661a 
Given a field `K`, the top element of `ValuationSubring K` is `K`, so top is also a field.

Co-authored-by: Xavier Genereux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erdOne erdOne erdOne left review comments

+1 more reviewer

@vihdzp vihdzp vihdzp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mattrobball mattrobball

Labels

ready-to-merge This PR has been sent to bors. t-ring-theory Ring theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xgenereux @erdOne @jcommelin @vihdzp @mattrobball