[Merged by Bors] - feat(Data/Nat/Factorization/PrimePow): add Nat.nontrivial_primeFactors_of_two_le_of_not_isPrimePow#33551
Closed
metakunt wants to merge 6 commits intoleanprover-community:masterfrom
Closed
Conversation
PR summary 4c87e1d930Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Contributor
Ruben-VandeVelde
left a comment
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
Thanks!
+awaiting-author
Ruben-VandeVelde
added
the
awaiting-author
Co-authored-by: Ruben Van de Velde <[email protected]>
metakunt
removed
the
awaiting-author
Collaborator
Author
|
Is it possible to add grind annotations on Finset.card_eq_zero, primeFactors_eq_empty? They are both simp annotated. |
metakunt
changed the title
joneugster
changed the title
joneugster
approved these changes
Jan 23, 2026
Contributor
joneugster
left a comment
joneugster
left a comment
There was a problem hiding this comment.
I'm afraid I don't know the answer about grind-annotations. My intuition would say yes, but I haven't used grind much yet.
Anyways the PR looks good to me and seems to already been approved once by @Ruben-VandeVelde.
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by joneugster. |
ghost
added
the
maintainer-merge
jcommelin
reviewed
Jan 23, 2026
jcommelin
added
the
awaiting-author
ocfnash
approved these changes
Jan 24, 2026
Contributor
|
✌️ metakunt can now approve this pull request. To approve and merge a pull request, simply reply with |
ghost
added
delegated
Co-authored-by: Oliver Nash <[email protected]>
Collaborator
Author
|
Thanks. bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 25, 2026
…s_of_two_le_of_not_isPrimePow (#33551)
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
YellPika
pushed a commit
to YellPika/mathlib4
that referenced
this pull request
Feb 3, 2026
…s_of_two_le_of_not_isPrimePow (leanprover-community#33551)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.