feat(ModelTheory/ElementarySubstructures): add a variant of Tarski-Vaught test taking sets as input#33520
Open
NoneMore wants to merge 6 commits intoleanprover-community:masterfrom
Open
feat(ModelTheory/ElementarySubstructures): add a variant of Tarski-Vaught test taking sets as input#33520NoneMore wants to merge 6 commits intoleanprover-community:masterfrom
NoneMore wants to merge 6 commits intoleanprover-community:masterfrom
Conversation
…ught test taking sets as input
github-actions
bot
added
new-contributor
PR summary c4c0a46689
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.ModelTheory.ElementarySubstructures | 771 | 773 | +2 (+0.26%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.ModelTheory.Graph |
1 |
11 filesMathlib.ModelTheory.Algebra.Field.IsAlgClosed Mathlib.ModelTheory.Bundled Mathlib.ModelTheory.Complexity Mathlib.ModelTheory.ElementarySubstructures Mathlib.ModelTheory.Equivalence Mathlib.ModelTheory.Fraisse Mathlib.ModelTheory.Order Mathlib.ModelTheory.Satisfiability Mathlib.ModelTheory.Skolem Mathlib.ModelTheory.Topology.Types Mathlib.ModelTheory.Types |
2 |
Declarations diff
+ MeetsDefinable
+ closure_eq_self
+ isElementary_closure
+ meetsDefinable
+ toElementarySubstructure
You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Citronhat
reviewed
Jan 28, 2026
Contributor
Citronhat
left a comment
Citronhat
left a comment
There was a problem hiding this comment.
I also don’t know the math here, but I again have some minor stylistic suggestions.
Contributor
Author
|
Thanks for your suggestions on styles of both PRs! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There should exist an
ElementarySubstructure.copysuch that we can directly bundle the set itself instaed of its closure as an elementary substructure.