[Merged by Bors] - chore(Algebra/Central/End): generalize Algebra.IsCentral.instEnd#33301
Closed
themathqueen wants to merge 11 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore(Algebra/Central/End): generalize Algebra.IsCentral.instEnd#33301themathqueen wants to merge 11 commits intoleanprover-community:masterfrom
Algebra.IsCentral.instEnd#33301themathqueen wants to merge 11 commits intoleanprover-community:masterfrom
Conversation
PR summary 51192f7a45
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.Module.LinearMap.End | 276 | 277 | +1 (+0.36%) |
| Mathlib.Algebra.Central.End | 811 | 812 | +1 (+0.12%) |
Import changes for all files
| Files | Import difference |
|---|---|
19 filesMathlib.Algebra.Category.Grp.ZModuleEquivalence Mathlib.Algebra.Category.ModuleCat.Basic Mathlib.Algebra.Category.ModuleCat.Colimits Mathlib.Algebra.Category.ModuleCat.FilteredColimits Mathlib.Algebra.Category.ModuleCat.Semi Mathlib.Algebra.Central.End Mathlib.Algebra.Module.Equiv.Basic Mathlib.Algebra.Module.LinearMap.End Mathlib.Algebra.Order.Module.Equiv Mathlib.CategoryTheory.Abelian.GrothendieckCategory.Coseparator Mathlib.CategoryTheory.Adjunction.Additive Mathlib.CategoryTheory.Generator.Abelian Mathlib.CategoryTheory.Generator.Preadditive Mathlib.CategoryTheory.Limits.ConcreteCategory.WithAlgebraicStructures Mathlib.CategoryTheory.Linear.Yoneda Mathlib.CategoryTheory.Preadditive.Yoneda.Basic Mathlib.LinearAlgebra.Finsupp.Defs Mathlib.LinearAlgebra.GeneralLinearGroup.Basic Mathlib.LinearAlgebra.GeneralLinearGroup |
1 |
Declarations diff
+ mem_center_iff
+ mem_submonoidCenter_iff
+ mem_subsemigroupCenter_iff
+ smulLeft
+ smulLeft_eq
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
1 task
AntoineChambert-Loir
added a commit
to AntoineChambert-Loir/mathlib4
that referenced
this pull request
Dec 26, 2025
2 tasks
1 task
ocfnash
reviewed
Jan 2, 2026
ocfnash
added
the
awaiting-author
themathqueen
removed
the
awaiting-author
Contributor
|
Thanks! bors d+ |
Contributor
|
✌️ themathqueen can now approve this pull request. To approve and merge a pull request, simply reply with |
ghost
added
the
delegated
github-actions
bot
added
the
large-import
Collaborator
Author
|
@ocfnash, there's a AddMonoidHom.smulLeft function, so I thought maybe we should extend that. But this comes with an additional 8 file import (3% increase). Revert? |
Contributor
Oh yeah, I think not worth the 3% hit just to extend something trivial. No harm leaving some breadcrumbs between the two in the form of doc string comments if you like. |
github-actions
bot
removed
the
large-import
themathqueen
added
auto-merge-after-CI
Collaborator
Author
|
bors r+ |
Contributor
|
Pull request successfully merged into master. Build succeeded! And happy new year! 🎉 |
mathlib-bors
bot
changed the title
Algebra.IsCentral.instEndAlgebra.IsCentral.instEnd
kim-em
pushed a commit
to kim-em/mathlib4
that referenced
this pull request
Jan 6, 2026
goliath-klein
pushed a commit
to PrParadoxy/mathlib4
that referenced
this pull request
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up during review of #33282.