Skip to content

[Merged by Bors] - feat(Algebra/Polynomial/Roots): Add ofMultiset_injective#32533

Closed
metakunt wants to merge 3 commits intoleanprover-community:masterfrom
metakunt:ofMultiset_injective
Closed

[Merged by Bors] - feat(Algebra/Polynomial/Roots): Add ofMultiset_injective#32533
metakunt wants to merge 3 commits intoleanprover-community:masterfrom
metakunt:ofMultiset_injective

Conversation

@metakunt
Copy link
Copy Markdown
Collaborator

@metakunt metakunt commented Dec 7, 2025

This shows that the product of roots (as a multiset) is injective.

@github-actions github-actions bot added new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-algebra Algebra (groups, rings, fields, etc) labels Dec 7, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 7, 2025 •
edited
Loading

PR summary bcc3f989a7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ ofMultiset_injective
+ rightInverse_ofMultiset_roots
+ roots_ofMultiset

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

SnirBroshi
SnirBroshi reviewed Dec 7, 2025
View reviewed changes
Vierkantor
Vierkantor approved these changes Dec 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I'm wondering about is the placement of these lemmas: ofMultiset_injective I would expect to live right next to ofMultiset. But this is the obvious way to prove it, so I think it's fine on balance.

bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Dec 12, 2025
mathlib-bors bot pushed a commit that referenced this pull request Dec 12, 2025
@metakunt
feat(Algebra/Polynomial/Roots): Add ofMultiset_injective (#32533)
c38ebf0 
This shows that the product of roots (as a multiset) is injective.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 12, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/Polynomial/Roots): Add ofMultiset_injective [Merged by Bors] - feat(Algebra/Polynomial/Roots): Add ofMultiset_injective Dec 12, 2025
@mathlib-bors mathlib-bors bot closed this Dec 12, 2025
@metakunt metakunt mentioned this pull request Mar 29, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vierkantor Vierkantor Vierkantor approved these changes

+1 more reviewer

@SnirBroshi SnirBroshi SnirBroshi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Vierkantor Vierkantor

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@metakunt @Vierkantor @SnirBroshi