Skip to content

[Merged by Bors] - refactor(LinearAlgebra/FiniteDimensional/Defs): move of_fact_finrank_eq_two#32296

Closed
jsm28 wants to merge 2 commits intoleanprover-community:masterfrom
jsm28:move_of_fact_finrank_eq_two
Closed

[Merged by Bors] - refactor(LinearAlgebra/FiniteDimensional/Defs): move of_fact_finrank_eq_two#32296
jsm28 wants to merge 2 commits intoleanprover-community:masterfrom
jsm28:move_of_fact_finrank_eq_two

Conversation

@jsm28
Copy link
Copy Markdown
Contributor

@jsm28 jsm28 commented Nov 30, 2025

Move of_fact_finrank_eq_two from Mathlib.Analysis.InnerProductSpace.TwoDim to Mathlib.LinearAlgebra.FiniteDimensional.Defs to avoid a large import in #31891 that was only in order to use that one lemma without needing the rest of Mathlib.Analysis.InnerProductSpace.TwoDim.

Open in Gitpod

@jsm28
refactor(LinearAlgebra/FiniteDimensional/Defs): move `of_fact_finrank…
ba5fe0d 
…_eq_two`

Move `of_fact_finrank_eq_two` from `Mathlib.Analysis.InnerProductSpace.TwoDim` to `Mathlib.LinearAlgebra.FiniteDimensional.Defs` to avoid a large import in leanprover-community#31891 that was only in order to use that one lemma without needing the rest of `Mathlib.Analysis.InnerProductSpace.TwoDim`.
@jsm28 jsm28 added easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields, etc) labels Nov 30, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 30, 2025 •
edited
Loading

PR summary addb2cace4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ of_fact_finrank_eq_two
- FiniteDimensional.of_fact_finrank_eq_two

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

This was referenced Dec 1, 2025
Closed
Open
Open
Open
Open
Ruben-VandeVelde
Ruben-VandeVelde approved these changes Dec 1, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems reasonable.

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 1, 2025

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 1, 2025
@riccardobrasca
Copy link
Copy Markdown
Member

riccardobrasca commented Dec 1, 2025

What about moving it to Basic? I see that Defs is not only about definitions, but let's try to not add material there.

@riccardobrasca
Copy link
Copy Markdown
Member

riccardobrasca commented Dec 1, 2025

Anyway this LGTM, thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 1, 2025

✌️ jsm28 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Dec 1, 2025
Ruben-VandeVelde
Ruben-VandeVelde reviewed Dec 1, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I'd argue that right next to of_fact_finrank_eq_succ makes perfect sense.

(One small comment on a second look, though.)

@riccardobrasca
Copy link
Copy Markdown
Member

riccardobrasca commented Dec 1, 2025

Hm, I'd argue that right next to of_fact_finrank_eq_succ makes perfect sense.

(One small comment on a second look, though.)

Ah yes, that makes sense, let's keep it there.

@jsm28
Copy link
Copy Markdown
Contributor Author

jsm28 commented Dec 1, 2025

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Dec 1, 2025
@jsm28
refactor(LinearAlgebra/FiniteDimensional/Defs): move `of_fact_finrank…
8e0ed7c 
…_eq_two` (#32296)

Move `of_fact_finrank_eq_two` from `Mathlib.Analysis.InnerProductSpace.TwoDim` to `Mathlib.LinearAlgebra.FiniteDimensional.Defs` to avoid a large import in #31891 that was only in order to use that one lemma without needing the rest of `Mathlib.Analysis.InnerProductSpace.TwoDim`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 1, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(LinearAlgebra/FiniteDimensional/Defs): move of_fact_finrank_eq_two [Merged by Bors] - refactor(LinearAlgebra/FiniteDimensional/Defs): move of_fact_finrank_eq_two Dec 1, 2025
@mathlib-bors mathlib-bors bot closed this Dec 1, 2025
@jsm28 jsm28 deleted the move_of_fact_finrank_eq_two branch December 1, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde approved these changes

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jsm28 @riccardobrasca @Ruben-VandeVelde