Skip to content

[Merged by Bors] - chore(Data/Finsupp): Rename degree_def#32179

Closed
WenrongZou wants to merge 1 commit intoleanprover-community:masterfrom
WenrongZou:degree_rename
Closed

[Merged by Bors] - chore(Data/Finsupp): Rename degree_def#32179
WenrongZou wants to merge 1 commit intoleanprover-community:masterfrom
WenrongZou:degree_rename

Conversation

@WenrongZou
Copy link
Copy Markdown
Contributor


Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Nov 27, 2025
@github-actions
Copy link
Copy Markdown

PR summary 9ea0d96e49

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ degree_apply
- degree_def

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@LLaurance
Copy link
Copy Markdown
Collaborator

How does deprecation work for such a recently added theorem?

@WenrongZou
Copy link
Copy Markdown
Contributor Author

How does deprecation work for such a recently added theorem?

One reviewer mentioned that it is better to use this name after the original PR has been closed.

@jcommelin
Copy link
Copy Markdown
Member

@LLaurance for changes that happen within a week, we usually don't deprecate.

Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Nov 28, 2025
mathlib-bors bot pushed a commit that referenced this pull request Nov 28, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 28, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Data/Finsupp): Rename degree_def [Merged by Bors] - chore(Data/Finsupp): Rename degree_def Nov 28, 2025
@mathlib-bors mathlib-bors bot closed this Nov 28, 2025
mathlib-bors bot pushed a commit that referenced this pull request Dec 11, 2025
@WenrongZou WenrongZou deleted the degree_rename branch December 18, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants