Skip to content

[Merged by Bors] - refactor(FieldTheory/IsAlgClosed,IsSepClosed): rename from factors to splits#32036

Closed
tb65536 wants to merge 1 commit intoleanprover-community:masterfrom
tb65536:tb_ren
Closed

[Merged by Bors] - refactor(FieldTheory/IsAlgClosed,IsSepClosed): rename from factors to splits#32036
tb65536 wants to merge 1 commit intoleanprover-community:masterfrom
tb65536:tb_ren

Conversation

@tb65536
Copy link
Copy Markdown
Contributor

@tb65536 tb65536 commented Nov 24, 2025

This PR corrects the names of the fields of IsAlgClosed and IsSepClosed.


Open in Gitpod

@tb65536 tb65536 added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-algebra Algebra (groups, rings, fields, etc) labels Nov 24, 2025
@github-actions
Copy link
Copy Markdown

PR summary c1ee2821db

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

- IsSepClosed.splits_of_separable
- splits

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Nov 24, 2025
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Nov 28, 2025
mathlib-bors bot pushed a commit that referenced this pull request Nov 28, 2025
…to `splits` (#32036)

This PR corrects the names of the fields of `IsAlgClosed` and `IsSepClosed`.

Co-authored-by: tb65536 <[email protected]>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 28, 2025

Pull request successfully merged into master.

Build succeeded:

1 similar comment
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 28, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(FieldTheory/IsAlgClosed,IsSepClosed): rename from factors to splits [Merged by Bors] - refactor(FieldTheory/IsAlgClosed,IsSepClosed): rename from factors to splits Nov 28, 2025
@mathlib-bors mathlib-bors bot closed this Nov 28, 2025
mathlib-bors bot pushed a commit that referenced this pull request Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants