Skip to content

[Merged by Bors] - feat(Geometry/Euclidean/Projection): map and subtype lemmas#32019

Closed
jsm28 wants to merge 7 commits intoleanprover-community:masterfrom
jsm28:orthogonalProjection_map
Closed

[Merged by Bors] - feat(Geometry/Euclidean/Projection): map and subtype lemmas#32019
jsm28 wants to merge 7 commits intoleanprover-community:masterfrom
jsm28:orthogonalProjection_map

Conversation

@jsm28
Copy link
Copy Markdown
Contributor

@jsm28 jsm28 commented Nov 23, 2025 •
edited by alreadydone
Loading

Add lemmas about mapping orthogonalProjection, reflection and orthogonalProjectionSpan under an affine isometry, and in particular mapping from a subspace to the full space.

Open in Gitpod

jsm28 added 2 commits November 23, 2025 21:31
@jsm28
feat(LinearAlgebra/AffineSpace/FiniteDimensional): `finiteDimensional…
a980bbd 
…_direction_map`

Add an instance that affine maps send finite-dimensional subspaces to
finite-dimensional subspaces.
@jsm28
feat(Geometry/Euclidean/Projection): map and subtype lemmas
8eee484 
Add lemmas about mapping `orthogonalProjection`, `reflection` and `orthogonalProjectionSpan` under an affine isometry, and in particular mapping from a subspace to the full space.
@jsm28 jsm28 added the t-euclidean-geometry Affine and axiomatic geometry label Nov 23, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 23, 2025 •
edited
Loading

PR summary 32831aa92a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ orthogonalProjectionSpan_map
+ orthogonalProjectionSpan_restrict
+ orthogonalProjection_map
+ orthogonalProjection_subtype
+ reflection_map
+ reflection_subtype

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@jsm28 jsm28 mentioned this pull request Nov 23, 2025
Closed
3 tasks
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Nov 23, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Nov 24, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

mathlib4-dependent-issues-bot commented Nov 24, 2025

This PR/issue depends on:

This was referenced Nov 30, 2025
Closed
Open
Open
Open
@jsm28 jsm28 mentioned this pull request Dec 11, 2025
Closed
1 task
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 11, 2025
@mathlib4-merge-conflict-bot
Copy link
Copy Markdown
Collaborator

mathlib4-merge-conflict-bot commented Dec 11, 2025

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 11, 2025
jcommelin
jcommelin reviewed Dec 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Dec 19, 2025
mathlib-bors bot pushed a commit that referenced this pull request Dec 19, 2025
@jsm28
feat(Geometry/Euclidean/Projection): map and subtype lemmas (#32019)
ab3b865 
Add lemmas about mapping `orthogonalProjection`, `reflection` and `orthogonalProjectionSpan` under an affine isometry, and in particular mapping from a subspace to the full space.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 19, 2025

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Dec 19, 2025
@jsm28
feat(Geometry/Euclidean/Projection): map and subtype lemmas (#32019)
38bc9ea 
Add lemmas about mapping `orthogonalProjection`, `reflection` and `orthogonalProjectionSpan` under an affine isometry, and in particular mapping from a subspace to the full space.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 19, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Geometry/Euclidean/Projection): map and subtype lemmas [Merged by Bors] - feat(Geometry/Euclidean/Projection): map and subtype lemmas Dec 19, 2025
@mathlib-bors mathlib-bors bot closed this Dec 19, 2025
@jsm28 jsm28 deleted the orthogonalProjection_map branch December 19, 2025 17:40
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
@jsm28 @goliath-klein
feat(Geometry/Euclidean/Projection): map and subtype lemmas (leanpr…
eaa94a8 
…over-community#32019)

Add lemmas about mapping `orthogonalProjection`, `reflection` and `orthogonalProjectionSpan` under an affine isometry, and in particular mapping from a subspace to the full space.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees

@JovanGerb JovanGerb

Labels

ready-to-merge This PR has been sent to bors. t-euclidean-geometry Affine and axiomatic geometry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jsm28 @mathlib4-dependent-issues-bot @mathlib4-merge-conflict-bot @jcommelin @JovanGerb