Skip to content

[Merged by Bors] - feat(Analysis/Convex/Quasiconvex): properties of quasiconcave functions#31548

Closed
AntoineChambert-Loir wants to merge 10 commits intoleanprover-community:masterfrom
AntoineChambert-Loir:ACLAD-Concavexity
Closed

[Merged by Bors] - feat(Analysis/Convex/Quasiconvex): properties of quasiconcave functions#31548
AntoineChambert-Loir wants to merge 10 commits intoleanprover-community:masterfrom
AntoineChambert-Loir:ACLAD-Concavexity

Conversation

@AntoineChambert-Loir
Copy link
Copy Markdown
Collaborator

@AntoineChambert-Loir AntoineChambert-Loir commented Nov 12, 2025

Prove properties of quasiconcave/quasiconvex functions:

  • monotony
  • restriction
  • connectedness of preimages

Co-authored with: @ADedecker

Open in Gitpod

@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Nov 12, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 12, 2025 •
edited
Loading

PR summary 964995275b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Convex.quasiconcaveOn_restrict
+ Convex.quasiconvexOn_restrict
+ sep_eq_inter_sep
- QuasiconcaveOn.mono
- QuasiconvexOn.mono
- sep_of_subset

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@AntoineChambert-Loir AntoineChambert-Loir mentioned this pull request Nov 12, 2025
Open
3 tasks
@EtienneC30 EtienneC30 added the t-analysis Analysis (normed *, calculus) label Nov 16, 2025
@EtienneC30 EtienneC30 removed their assignment Nov 16, 2025
@mathlib4-merge-conflict-bot
Copy link
Copy Markdown
Collaborator

mathlib4-merge-conflict-bot commented Nov 19, 2025

This pull request has conflicts, please merge master and resolve them.

@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 19, 2025
@github-actions github-actions bot removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) large-import Automatically added label for PRs with a significant increase in transitive imports labels Nov 20, 2025
j-loreaux
j-loreaux reviewed Nov 25, 2025
View reviewed changes
@j-loreaux j-loreaux added awaiting-author A reviewer has asked the author a question or requested changes. t-analysis Analysis (normed *, calculus) and removed t-analysis Analysis (normed *, calculus) labels Nov 25, 2025
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Nov 27, 2025
@AntoineChambert-Loir AntoineChambert-Loir removed the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 27, 2025
j-loreaux
j-loreaux reviewed Nov 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you like the naming suggestion, feel free to merge after making the substitution everywhere.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 27, 2025

✌️ AntoineChambert-Loir can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Nov 27, 2025
@j-loreaux
Copy link
Copy Markdown
Contributor

j-loreaux commented Nov 27, 2025

I forgot to say: I think the import increase is fine in part because this is a leaf file. It can be split later if it starts gaining many downstream files.

@github-actions github-actions bot removed the large-import Automatically added label for PRs with a significant increase in transitive imports label Nov 29, 2025
@AntoineChambert-Loir
Copy link
Copy Markdown
Collaborator Author

AntoineChambert-Loir commented Nov 29, 2025

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Nov 29, 2025
@AntoineChambert-Loir
feat(Analysis/Convex/Quasiconvex): properties of quasiconcave functio…
1fb75e1 
…ns (#31548)

Prove properties of quasiconcave/quasiconvex functions:
* monotony
* restriction
* connectedness of preimages 

Co-authored with: @ADedecker
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 29, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Analysis/Convex/Quasiconvex): properties of quasiconcave functions [Merged by Bors] - feat(Analysis/Convex/Quasiconvex): properties of quasiconcave functions Nov 29, 2025
@mathlib-bors mathlib-bors bot closed this Nov 29, 2025
@Ruben-VandeVelde Ruben-VandeVelde mentioned this pull request Dec 10, 2025
Closed
mathlib-bors bot pushed a commit that referenced this pull request Dec 11, 2025
@Ruben-VandeVelde
chore: add missing deprecations (#32705)
f3f5e6f 
From #32074, #32107, #31871, #32061, #32138, #32036, #32179, #32092, #31548, #32228, and perhaps some more.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-loreaux j-loreaux j-loreaux left review comments

Assignees

@j-loreaux j-loreaux

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-analysis Analysis (normed *, calculus)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AntoineChambert-Loir @mathlib4-merge-conflict-bot @j-loreaux @EtienneC30