Skip to content

[Merged by Bors] - feat(Filter): replace coframe instance with better defeqs#31264

Closed
plp127 wants to merge 11 commits intoleanprover-community:masterfrom
plp127:aliu/filter_coframe
Closed

[Merged by Bors] - feat(Filter): replace coframe instance with better defeqs#31264
plp127 wants to merge 11 commits intoleanprover-community:masterfrom
plp127:aliu/filter_coframe

Conversation

@plp127
Copy link
Copy Markdown
Contributor

@plp127 plp127 commented Nov 4, 2025 •
edited
Loading

Replace the Filter.instCoframe with explicitly given operations. Prove Filter.mem_sdiff and Filter.hnot_def.

The definitions I chose here are somewhat arbitrary, but I think they're better than what we had before. I chose these specific definitions based on a conversation with AI, but I did not use AI to help me write this PR.

Open in Gitpod

@plp127 plp127 added the t-order Order theory label Nov 4, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 4, 2025 •
edited
Loading

PR summary b3cf7a02d3

Import changes for modified files

No significant changes to the import graph
M scripts/count-trans-deps.py
M scripts/count-trans-deps.py
M scripts/count-trans-deps.py

Import changes for all files
Files Import difference

Declarations diff

+ hnot_def
+ instHNot
+ instSDiff
+ mem_sdiff
+ mem_sdiff_iff_union
- coframeMinimalAxioms

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

plp127
plp127 commented Nov 4, 2025
View reviewed changes
Vierkantor
Vierkantor approved these changes Nov 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but someone who actually uses filters should verify.

maintainer delegate

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 14, 2025

🚀 Pull request has been placed on the maintainer queue by Vierkantor.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Nov 14, 2025
@riccardobrasca
Copy link
Copy Markdown
Member

riccardobrasca commented Nov 16, 2025

LGTM, but please take into account the comments.

@plp127 plp127 added the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 16, 2025
@plp127 plp127 removed the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 22, 2025
@plp127 plp127 mentioned this pull request Nov 22, 2025
Open
1 task
ocfnash
ocfnash approved these changes Nov 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 24, 2025

✌️ plp127 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Nov 24, 2025
@plp127
Copy link
Copy Markdown
Contributor Author

plp127 commented Nov 30, 2025

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Dec 1, 2025
@plp127
feat(Filter): replace coframe instance with better defeqs (#31264)
dc19f2a 
Replace the `Filter.instCoframe` with explicitly given operations. Prove `Filter.mem_sdiff` and `Filter.hnot_def`.

The definitions I chose here are somewhat arbitrary, but I think they're better than what we had before. I chose these specific definitions based on a conversation with AI, but I did not use AI to help me write this PR.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 1, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Filter): replace coframe instance with better defeqs [Merged by Bors] - feat(Filter): replace coframe instance with better defeqs Dec 1, 2025
@mathlib-bors mathlib-bors bot closed this Dec 1, 2025
@plp127 plp127 deleted the aliu/filter_coframe branch December 1, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vierkantor Vierkantor Vierkantor approved these changes

@ocfnash ocfnash ocfnash approved these changes

Assignees

@Vierkantor Vierkantor

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-order Order theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@plp127 @riccardobrasca @Vierkantor @ocfnash