Skip to content

[Merged by Bors] - feat(Algebra): saturation of a submonoid#31132

Closed
kckennylau wants to merge 12 commits intoleanprover-community:masterfrom
kckennylau:monoid-saturation
Closed

[Merged by Bors] - feat(Algebra): saturation of a submonoid#31132
kckennylau wants to merge 12 commits intoleanprover-community:masterfrom
kckennylau:monoid-saturation

Conversation

@kckennylau
Copy link
Copy Markdown
Collaborator

This PR defines the saturation of a submonoid and the type of saturated submonoids.

It is used for the context of localisations.

Caveat: there is a similarly named predicate called AddSubgroup.Saturated.

Zulip:


Open in Gitpod

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Oct 31, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 31, 2025

PR summary 0fbcb39f55

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Algebra.Group.Submonoid.Saturation (new file) 418

Declarations diff

+ AddSubgroup.Saturated
+ AddSubgroup.ker_saturated
+ AddSubgroup.saturated_iff_nsmul
+ MulSaturated
+ PowSaturated
+ SaturatedAddSubmonoid
+ SaturatedSubmonoid
+ Subgroup.Saturated
+ Subgroup.saturated_iff_npow
+ bot_def
+ ext
+ ext'
+ gc_saturation
+ giSaturation
+ iInf
+ iSup_def
+ inf
+ instance (M : Type*) [MulOneClass M] :
+ instance : CompleteSemilatticeInf (SaturatedSubmonoid M)
+ instance : InfSet (SaturatedSubmonoid M)
+ instance : Min (SaturatedSubmonoid M)
+ instance : PartialOrder (SaturatedSubmonoid M) := .ofSetLike ..
+ instance : SetLike (SaturatedSubmonoid M) M
+ instance : SubmonoidClass (SaturatedSubmonoid M) M
+ instance : Top (SaturatedSubmonoid M)
+ le_toSubmonoid_saturation
+ mem_bot_iff
+ mem_sInf
+ mem_saturation_iff
+ mem_saturation_iff'
+ mem_saturation_iff_exists_dvd
+ mem_toSubmonoid
+ mem_top
+ mul_mem_iff
+ of_left
+ of_right
+ powSaturated_iff_npow
+ sInf
+ sSup_def
+ saturation
+ saturation_bot
+ saturation_iSup
+ saturation_induction
+ saturation_le_iff_le
+ saturation_le_of_le
+ saturation_sSup
+ saturation_sup
+ saturation_toSubmonoid
+ saturation_top
+ sup_def
+ toSubmonoid_injective
+ top
- Saturated
- saturated_iff_npow

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 19, 2025
@mathlib4-merge-conflict-bot
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 20, 2025
@alreadydone alreadydone changed the title Feat(Algebra): saturation of a submonoid feat(Algebra): saturation of a submonoid Nov 28, 2025
Copy link
Copy Markdown
Contributor

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have Subgroup.Saturated, which is a mathematically different notion, and the file defining it is not imported anywhere. It looks like the literature prefers this notion for the name "saturated". @jcommelin could you say something about what Subgroup.Saturated was useful for (as the author of the file)?

@kckennylau
Copy link
Copy Markdown
Collaborator Author

@b-mehta @jcommelin leanprover-community/mathlib3#8137 it was for liquid tensor

Copy link
Copy Markdown
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why you are not additivizing everything?

@kckennylau
Copy link
Copy Markdown
Collaborator Author

I'll additivize it.

@kbuzzard
Copy link
Copy Markdown
Member

kbuzzard commented Mar 3, 2026

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 3, 2026

✌️ kckennylau can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Mar 3, 2026
@kckennylau
Copy link
Copy Markdown
Collaborator Author

bors r+

1 similar comment
@bryangingechen
Copy link
Copy Markdown
Contributor

bors r+

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Mar 3, 2026
mathlib-bors bot pushed a commit that referenced this pull request Mar 3, 2026
This PR defines the saturation of a submonoid and the type of saturated submonoids.

It is used for the context of localisations.

Caveat: there is a similarly named predicate called `AddSubgroup.Saturated`.

Zulip:
* [mathlib4 > saturation of a submonoid](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/saturation.20of.20a.20submonoid/with/548242862)
* [#Is there code for X? > Closure of Submonoid in CommMonoids](https://leanprover.zulipchat.com/#narrow/channel/217875-Is-there-code-for-X.3F/topic/Closure.20of.20Submonoid.20in.20CommMonoids/near/419087778)
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 3, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra): saturation of a submonoid [Merged by Bors] - feat(Algebra): saturation of a submonoid Mar 3, 2026
@mathlib-bors mathlib-bors bot closed this Mar 3, 2026
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Mar 10, 2026
This PR defines the saturation of a submonoid and the type of saturated submonoids.

It is used for the context of localisations.

Caveat: there is a similarly named predicate called `AddSubgroup.Saturated`.

Zulip:
* [mathlib4 > saturation of a submonoid](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/saturation.20of.20a.20submonoid/with/548242862)
* [#Is there code for X? > Closure of Submonoid in CommMonoids](https://leanprover.zulipchat.com/#narrow/channel/217875-Is-there-code-for-X.3F/topic/Closure.20of.20Submonoid.20in.20CommMonoids/near/419087778)
pevogam pushed a commit to pevogam/mathlib4 that referenced this pull request Mar 19, 2026
This PR defines the saturation of a submonoid and the type of saturated submonoids.

It is used for the context of localisations.

Caveat: there is a similarly named predicate called `AddSubgroup.Saturated`.

Zulip:
* [mathlib4 > saturation of a submonoid](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/saturation.20of.20a.20submonoid/with/548242862)
* [#Is there code for X? > Closure of Submonoid in CommMonoids](https://leanprover.zulipchat.com/#narrow/channel/217875-Is-there-code-for-X.3F/topic/Closure.20of.20Submonoid.20in.20CommMonoids/near/419087778)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants