[Merged by Bors] - feat(Algebra): saturation of a submonoid#31132
[Merged by Bors] - feat(Algebra): saturation of a submonoid#31132kckennylau wants to merge 12 commits intoleanprover-community:masterfrom
Conversation
PR summary 0fbcb39f55Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
|
This pull request has conflicts, please merge |
b-mehta
left a comment
There was a problem hiding this comment.
We also have Subgroup.Saturated, which is a mathematically different notion, and the file defining it is not imported anywhere. It looks like the literature prefers this notion for the name "saturated". @jcommelin could you say something about what Subgroup.Saturated was useful for (as the author of the file)?
|
@b-mehta @jcommelin leanprover-community/mathlib3#8137 it was for liquid tensor |
riccardobrasca
left a comment
There was a problem hiding this comment.
Is there a reason why you are not additivizing everything?
|
I'll additivize it. |
|
bors d+ |
|
✌️ kckennylau can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Kevin Buzzard <[email protected]>
|
bors r+ |
1 similar comment
|
bors r+ |
This PR defines the saturation of a submonoid and the type of saturated submonoids. It is used for the context of localisations. Caveat: there is a similarly named predicate called `AddSubgroup.Saturated`. Zulip: * [mathlib4 > saturation of a submonoid](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/saturation.20of.20a.20submonoid/with/548242862) * [#Is there code for X? > Closure of Submonoid in CommMonoids](https://leanprover.zulipchat.com/#narrow/channel/217875-Is-there-code-for-X.3F/topic/Closure.20of.20Submonoid.20in.20CommMonoids/near/419087778)
|
Pull request successfully merged into master. Build succeeded: |
This PR defines the saturation of a submonoid and the type of saturated submonoids. It is used for the context of localisations. Caveat: there is a similarly named predicate called `AddSubgroup.Saturated`. Zulip: * [mathlib4 > saturation of a submonoid](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/saturation.20of.20a.20submonoid/with/548242862) * [#Is there code for X? > Closure of Submonoid in CommMonoids](https://leanprover.zulipchat.com/#narrow/channel/217875-Is-there-code-for-X.3F/topic/Closure.20of.20Submonoid.20in.20CommMonoids/near/419087778)
This PR defines the saturation of a submonoid and the type of saturated submonoids. It is used for the context of localisations. Caveat: there is a similarly named predicate called `AddSubgroup.Saturated`. Zulip: * [mathlib4 > saturation of a submonoid](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/saturation.20of.20a.20submonoid/with/548242862) * [#Is there code for X? > Closure of Submonoid in CommMonoids](https://leanprover.zulipchat.com/#narrow/channel/217875-Is-there-code-for-X.3F/topic/Closure.20of.20Submonoid.20in.20CommMonoids/near/419087778)
This PR defines the saturation of a submonoid and the type of saturated submonoids.
It is used for the context of localisations.
Caveat: there is a similarly named predicate called
AddSubgroup.Saturated.Zulip: