Skip to content

[Merged by Bors] - feat(Homology) : compatibility of map between Ext#31046

Closed
Thmoas-Guan wants to merge 133 commits intoleanprover-community:masterfrom
Thmoas-Guan:Ext-Map-by-Exact-Functor
Closed

[Merged by Bors] - feat(Homology) : compatibility of map between Ext#31046
Thmoas-Guan wants to merge 133 commits intoleanprover-community:masterfrom
Thmoas-Guan:Ext-Map-by-Exact-Functor

Conversation

@Thmoas-Guan
Copy link
Copy Markdown
Collaborator

@Thmoas-Guan Thmoas-Guan commented Oct 29, 2025

In this PR, we proved the compatibility of map between Ext induced by exact functor with
1: mk_0 2: comp 3: extClass


Open in Gitpod

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Oct 29, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 29, 2025

PR summary 053a0031eb

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.Homology.DerivedCategory.Ext.Map 1396 1406 +10 (+0.72%)
Mathlib.Algebra.Homology.HomologicalComplexAbelian 842 846 +4 (+0.48%)
Mathlib.Algebra.Homology.HomotopyCategory.ShortExact 1345 1349 +4 (+0.30%)
Mathlib.Algebra.Homology.DerivedCategory.Basic 1349 1353 +4 (+0.30%)
Mathlib.Algebra.Homology.DerivedCategory.ShortExact 1354 1358 +4 (+0.30%)
Mathlib.Algebra.Homology.DerivedCategory.ExactFunctor 1357 1361 +4 (+0.29%)
Mathlib.Algebra.Homology.DerivedCategory.Ext.ExtClass 1380 1383 +3 (+0.22%)
Import changes for all files
Files Import difference
Mathlib.CategoryTheory.Abelian.Injective.Dimension Mathlib.CategoryTheory.Abelian.Projective.Dimension 2
27 files Mathlib.Algebra.Category.ModuleCat.Ext.HasExt Mathlib.Algebra.Homology.CochainComplexPlus Mathlib.Algebra.Homology.DerivedCategory.Ext.Basic Mathlib.Algebra.Homology.DerivedCategory.Ext.EnoughInjectives Mathlib.Algebra.Homology.DerivedCategory.Ext.EnoughProjectives Mathlib.Algebra.Homology.DerivedCategory.Ext.ExactSequences Mathlib.Algebra.Homology.DerivedCategory.Ext.ExtClass Mathlib.Algebra.Homology.DerivedCategory.Ext.Linear Mathlib.Algebra.Homology.DerivedCategory.Ext.TStructure Mathlib.Algebra.Homology.DerivedCategory.Fractions Mathlib.Algebra.Homology.DerivedCategory.FullyFaithful Mathlib.Algebra.Homology.DerivedCategory.KInjective Mathlib.Algebra.Homology.DerivedCategory.KProjective Mathlib.Algebra.Homology.DerivedCategory.TStructure Mathlib.Algebra.Homology.Embedding.AreComplementary Mathlib.Algebra.Homology.Embedding.CochainComplex Mathlib.Algebra.Homology.Embedding.TruncLEHomology Mathlib.Algebra.Homology.Factorizations.CM5a Mathlib.Algebra.Homology.Factorizations.CM5b Mathlib.Algebra.Homology.HomotopyCategory.KInjective Mathlib.Algebra.Homology.HomotopyCategory.KProjective Mathlib.CategoryTheory.Abelian.Injective.Ext Mathlib.CategoryTheory.Abelian.Injective.Extend Mathlib.CategoryTheory.Abelian.Projective.Ext Mathlib.CategoryTheory.Abelian.Projective.Extend Mathlib.CategoryTheory.Sites.SheafCohomology.Basic Mathlib.CategoryTheory.Sites.SheafCohomology.MayerVietoris
3
11 files Mathlib.Algebra.Homology.DerivedCategory.Basic Mathlib.Algebra.Homology.DerivedCategory.ExactFunctor Mathlib.Algebra.Homology.DerivedCategory.HomologySequence Mathlib.Algebra.Homology.DerivedCategory.Linear Mathlib.Algebra.Homology.DerivedCategory.ShortExact Mathlib.Algebra.Homology.DerivedCategory.SingleTriangle Mathlib.Algebra.Homology.DerivedCategory.SmallShiftedHom Mathlib.Algebra.Homology.HomologicalComplexAbelian Mathlib.Algebra.Homology.HomotopyCategory.Acyclic Mathlib.Algebra.Homology.HomotopyCategory.HomologicalFunctor Mathlib.Algebra.Homology.HomotopyCategory.ShortExact
4
Mathlib.Algebra.Homology.DerivedCategory.Ext.Map 10

Declarations diff

+ DerivedCategory.map_triangleOfSESδ
+ Q_obj_single_obj
+ ShortComplex.ShortExact.mapShiftedHom_singleδ
+ ShortComplex.ShortExact.mapShiftedHom_singleδ'
+ descShortComplex_naturality
+ descShortComplex_triangleOfSESδ
+ instance [F.PreservesZeroMorphisms] {J : Type*} [Category* J] [HasColimitsOfShape J C]
+ instance [F.PreservesZeroMorphisms] {J : Type*} [Category* J] [HasLimitsOfShape J C]
+ instance [HasFiniteColimits C] [F.PreservesZeroMorphisms] [PreservesFiniteColimits F] :
+ instance [HasFiniteLimits C] [F.PreservesZeroMorphisms] [PreservesFiniteLimits F] :
+ mapDerivedCategoryFactors_hom_naturality
+ mapDerivedCategoryFactors_inv_app_mapDerivedCategorySingleFunctor_hom_app
+ mapDerivedCategorySingleFunctor_inv_app_mapDerivedCategoryFactors_hom_app
+ mapExactFunctor_comp
+ mapExactFunctor_extClass
+ mapExactFunctor_mk₀
+ mapExactFunctor₀
+ mapHomologicalComplexIso_hom_descShortComplex
+ triangleOfSESδ_naturality

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (8.00, 0.00)
Current number Change Type
6887 8 backward.isDefEq.respectTransparency

Current commit 916956d87f
Reference commit 053a0031eb

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 5, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Nov 9, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 12, 2025
@joelriou
Copy link
Copy Markdown
Contributor

Could you make a (smaller) PR containing this material but without what is related to the technical compatibility with extClass?

Comment thread Mathlib/Algebra/Homology/DerivedCategory/Ext/Map.lean Outdated
removing big haves

Co-authored-by: Joël Riou <[email protected]>
Comment thread Mathlib/Algebra/Homology/DerivedCategory/Ext/Map.lean Outdated
Comment thread Mathlib/Algebra/Homology/DerivedCategory/Ext/Map.lean Outdated
Comment thread Mathlib/Algebra/Homology/DerivedCategory/Ext/Map.lean Outdated
Comment thread Mathlib/Algebra/Homology/DerivedCategory/ExactFunctor.lean Outdated
Comment thread Mathlib/Algebra/Homology/DerivedCategory/ExactFunctor.lean Outdated
Comment thread Mathlib/Algebra/Homology/DerivedCategory/Ext/Map.lean Outdated
Comment thread Mathlib/Algebra/Homology/DerivedCategory/Ext/Map.lean Outdated
Comment thread Mathlib/Algebra/Homology/DerivedCategory/Ext/Map.lean Outdated
@joelriou joelriou added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 7, 2026
@Thmoas-Guan Thmoas-Guan removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 7, 2026
@joelriou joelriou added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 7, 2026
@Thmoas-Guan Thmoas-Guan removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 7, 2026
@joelriou
Copy link
Copy Markdown
Contributor

joelriou commented Apr 7, 2026

Thanks!

bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Apr 7, 2026
mathlib-bors bot pushed a commit that referenced this pull request Apr 7, 2026
In this PR, we proved the compatibility of map between `Ext` induced by exact functor with
1: `mk_0` 2: `comp` 3: `extClass`

Co-authored-by: Joël Riou <[email protected]>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 7, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Homology) : compatibility of map between Ext [Merged by Bors] - feat(Homology) : compatibility of map between Ext Apr 7, 2026
@mathlib-bors mathlib-bors bot closed this Apr 7, 2026
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Apr 10, 2026
…nity#31046)

In this PR, we proved the compatibility of map between `Ext` induced by exact functor with
1: `mk_0` 2: `comp` 3: `extClass`

Co-authored-by: Joël Riou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants