Skip to content

[Merged by Bors] - feat(Geometry/Euclidean/Angle/Oriented/RightAngle): angles less than π / 2#30600

Closed
jsm28 wants to merge 3 commits intoleanprover-community:masterfrom
jsm28:abs_oangle_toReal_lt_pi_div_two
Closed

[Merged by Bors] - feat(Geometry/Euclidean/Angle/Oriented/RightAngle): angles less than π / 2#30600
jsm28 wants to merge 3 commits intoleanprover-community:masterfrom
jsm28:abs_oangle_toReal_lt_pi_div_two

Conversation

@jsm28
Copy link
Copy Markdown
Contributor

@jsm28 jsm28 commented Oct 16, 2025

Add a lemma that an oriented angle in a right-angled triangle is less than π / 2, even in degenerate cases (there's already a corresponding lemma for unoriented angles, but that one needs to exclude some degenerate cases because of the different default values for oriented and unoriented angles involving zero vectors). Deduce lemmas that, for such angles involved in right-angled triangles, equality of the angles (i.e. equality mod 2π) follows from equality of twice the angles (i.e. equality of the angles mod π).


Open in Gitpod

jsm28 added 2 commits October 16, 2025 01:10
…ality of twice angles

Add lemmas that two angles less than `π / 2` are equal if and only if
twice those angles are equal, along with a separate lemma

```lean
lemma toReal_neg_eq_neg_toReal_iff {θ : Angle} : (-θ).toReal = -(θ.toReal) ↔ θ ≠ π := by
```

which isn't directly connected but turns out to be useful in the same
application (dealing with angles in right-angled triangles that are
less then `π / 2`, when you have two such triangles that are
oppositely-oriented).
…`π / 2`

Add a lemma that an oriented angle in a right-angled triangle is less
than `π / 2`, even in degenerate cases (there's already a
corresponding lemma for unoriented angles, but that one needs to
exclude some degenerate cases because of the different default values
for oriented and unoriented angles involving zero vectors).  Deduce
lemmas that, for such angles involved in right-angled triangles,
equality of the angles (i.e. equality mod 2π) follows from equality of
twice the angles (i.e. equality of the angles mod π).
@jsm28 jsm28 added the t-euclidean-geometry Affine and axiomatic geometry label Oct 16, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 16, 2025

PR summary 4086670d5a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ abs_oangle_toReal_lt_pi_div_two_of_angle_eq_pi_div_two
+ oangle_eq_oangle_of_two_zsmul_eq_of_angle_eq_pi_div_two
+ oangle_eq_oangle_rev_of_two_zsmul_eq_of_angle_eq_pi_div_two

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Oct 16, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Oct 27, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Oct 28, 2025
mathlib-bors bot pushed a commit that referenced this pull request Oct 28, 2025
…`π / 2` (#30600)

Add a lemma that an oriented angle in a right-angled triangle is less than `π / 2`, even in degenerate cases (there's already a corresponding lemma for unoriented angles, but that one needs to exclude some degenerate cases because of the different default values for oriented and unoriented angles involving zero vectors).  Deduce lemmas that, for such angles involved in right-angled triangles, equality of the angles (i.e. equality mod 2π) follows from equality of twice the angles (i.e. equality of the angles mod π).
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 28, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Geometry/Euclidean/Angle/Oriented/RightAngle): angles less than π / 2 [Merged by Bors] - feat(Geometry/Euclidean/Angle/Oriented/RightAngle): angles less than π / 2 Oct 28, 2025
@mathlib-bors mathlib-bors bot closed this Oct 28, 2025
@jsm28 jsm28 deleted the abs_oangle_toReal_lt_pi_div_two branch October 28, 2025 10:45
BeibeiX0 pushed a commit to BeibeiX0/mathlib4 that referenced this pull request Nov 7, 2025
…`π / 2` (leanprover-community#30600)

Add a lemma that an oriented angle in a right-angled triangle is less than `π / 2`, even in degenerate cases (there's already a corresponding lemma for unoriented angles, but that one needs to exclude some degenerate cases because of the different default values for oriented and unoriented angles involving zero vectors).  Deduce lemmas that, for such angles involved in right-angled triangles, equality of the angles (i.e. equality mod 2π) follows from equality of twice the angles (i.e. equality of the angles mod π).
FormulaRabbit81 pushed a commit to FormulaRabbit81/mathlib4 that referenced this pull request Nov 8, 2025
…`π / 2` (leanprover-community#30600)

Add a lemma that an oriented angle in a right-angled triangle is less than `π / 2`, even in degenerate cases (there's already a corresponding lemma for unoriented angles, but that one needs to exclude some degenerate cases because of the different default values for oriented and unoriented angles involving zero vectors).  Deduce lemmas that, for such angles involved in right-angled triangles, equality of the angles (i.e. equality mod 2π) follows from equality of twice the angles (i.e. equality of the angles mod π).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-euclidean-geometry Affine and axiomatic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants