Skip to content

[Merged by Bors] - chore: fix formatting for deprecation dates#30297

Closed
Ruben-VandeVelde wants to merge 1 commit intoleanprover-community:masterfrom
Ruben-VandeVelde:fmt-dep-date
Closed

[Merged by Bors] - chore: fix formatting for deprecation dates#30297
Ruben-VandeVelde wants to merge 1 commit intoleanprover-community:masterfrom
Ruben-VandeVelde:fmt-dep-date

Conversation

@Ruben-VandeVelde
Copy link
Copy Markdown
Contributor

Also update the date to when the PR (#27699) was actually landed.


Open in Gitpod

Also update the date to when the PR was actually landed.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 7, 2025

PR summary ee767324a4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Oct 7, 2025

Thanks!
maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 7, 2025

🚀 Pull request has been placed on the maintainer queue by grunweg.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Oct 7, 2025
@adomani
Copy link
Copy Markdown
Contributor

adomani commented Oct 7, 2025

Thanks!

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Oct 7, 2025
mathlib-bors bot pushed a commit that referenced this pull request Oct 7, 2025
Also update the date to when the PR (#27699) was actually landed.
@bryangingechen
Copy link
Copy Markdown
Contributor

bryangingechen commented Oct 7, 2025

Beat me to it! I wonder if the deprecated attribute should be stricter about what's allowed in since?

@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Oct 7, 2025

At the very least, enforcing that the content has the format YYYY-MM-DD should be easy (and catch most mistakes).

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 7, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: fix formatting for deprecation dates [Merged by Bors] - chore: fix formatting for deprecation dates Oct 7, 2025
@mathlib-bors mathlib-bors bot closed this Oct 7, 2025
Jlh18 pushed a commit to Jlh18/mathlib4 that referenced this pull request Oct 14, 2025
BeibeiX0 pushed a commit to BeibeiX0/mathlib4 that referenced this pull request Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants