[Merged by Bors] - feat(InfinitePlace/Embeddings): remove dependency of IsMixed/IsUnmixed on Extension.#29945
Closed
smmercuri wants to merge 3 commits intoleanprover-community:masterfrom
Closed
Conversation
PR summary f4506f7151Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
github-actions
bot
added
the
t-number-theory
1 task
xroblot
approved these changes
Sep 26, 2025
Collaborator
xroblot
left a comment
xroblot
left a comment
There was a problem hiding this comment.
Yes, that looks like a better way to define IsMixed indeed. Thanks!
Member
|
Thanks! bors merge |
ghost
added
the
mathlib-bors bot
pushed a commit
that referenced
this pull request
Sep 28, 2025
…ixed` on `Extension`. (#29945) - Remove the unnecessary dependency of `ComplexEmbedding.IsUnmixed` on the subtype `ComplexEmbedding.Extension`, which makes it easier to use as it does not require the construction of a term of `ComplexEmbedding.Extension`. This also aligns it more closely with [`InfinitePlace.IsUnramified`](https://github.com/leanprover-community/mathlib4/blob/f4506f7151c9057fd9f8714b2a1f13a647fe2352/Mathlib/NumberTheory/NumberField/InfinitePlace/Ramification.lean#L162-L165), of which it is intended to be an analogue. - Ditto for `ComplexEmbedding.IsMixed`. - The definition of `IsUnmixed` is now given in simp-normal form.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
IsMixed/IsUnmixed on Extension.IsMixed/IsUnmixed on Extension.
joelriou
pushed a commit
to joelriou/mathlib4
that referenced
this pull request
Oct 2, 2025
…ixed` on `Extension`. (leanprover-community#29945) - Remove the unnecessary dependency of `ComplexEmbedding.IsUnmixed` on the subtype `ComplexEmbedding.Extension`, which makes it easier to use as it does not require the construction of a term of `ComplexEmbedding.Extension`. This also aligns it more closely with [`InfinitePlace.IsUnramified`](https://github.com/leanprover-community/mathlib4/blob/f4506f7151c9057fd9f8714b2a1f13a647fe2352/Mathlib/NumberTheory/NumberField/InfinitePlace/Ramification.lean#L162-L165), of which it is intended to be an analogue. - Ditto for `ComplexEmbedding.IsMixed`. - The definition of `IsUnmixed` is now given in simp-normal form.
mitchell-horner
pushed a commit
to mitchell-horner/mathlib4
that referenced
this pull request
Oct 6, 2025
…ixed` on `Extension`. (leanprover-community#29945) - Remove the unnecessary dependency of `ComplexEmbedding.IsUnmixed` on the subtype `ComplexEmbedding.Extension`, which makes it easier to use as it does not require the construction of a term of `ComplexEmbedding.Extension`. This also aligns it more closely with [`InfinitePlace.IsUnramified`](https://github.com/leanprover-community/mathlib4/blob/f4506f7151c9057fd9f8714b2a1f13a647fe2352/Mathlib/NumberTheory/NumberField/InfinitePlace/Ramification.lean#L162-L165), of which it is intended to be an analogue. - Ditto for `ComplexEmbedding.IsMixed`. - The definition of `IsUnmixed` is now given in simp-normal form.
BeibeiX0
pushed a commit
to BeibeiX0/mathlib4
that referenced
this pull request
Nov 7, 2025
…ixed` on `Extension`. (leanprover-community#29945) - Remove the unnecessary dependency of `ComplexEmbedding.IsUnmixed` on the subtype `ComplexEmbedding.Extension`, which makes it easier to use as it does not require the construction of a term of `ComplexEmbedding.Extension`. This also aligns it more closely with [`InfinitePlace.IsUnramified`](https://github.com/leanprover-community/mathlib4/blob/f4506f7151c9057fd9f8714b2a1f13a647fe2352/Mathlib/NumberTheory/NumberField/InfinitePlace/Ramification.lean#L162-L165), of which it is intended to be an analogue. - Ditto for `ComplexEmbedding.IsMixed`. - The definition of `IsUnmixed` is now given in simp-normal form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ComplexEmbedding.IsUnmixedon the subtypeComplexEmbedding.Extension, which makes it easier to use as it does not require the construction of a term ofComplexEmbedding.Extension. This also aligns it more closely withInfinitePlace.IsUnramified, of which it is intended to be an analogue.ComplexEmbedding.IsMixed.IsUnmixedis now given in simp-normal form.