Skip to content

[Merged by Bors] - feat(Analysis/Convex): Lifting convex sets along scalar towers#29075

Closed
Timeroot wants to merge 8 commits intoleanprover-community:masterfrom
Timeroot:timeroot/convex_lift
Closed

[Merged by Bors] - feat(Analysis/Convex): Lifting convex sets along scalar towers#29075
Timeroot wants to merge 8 commits intoleanprover-community:masterfrom
Timeroot:timeroot/convex_lift

Conversation

@Timeroot
Copy link
Copy Markdown
Collaborator

@Timeroot Timeroot commented Aug 28, 2025

This PR continues the work from #25637.

Original PR: #25637

@Timeroot Timeroot mentioned this pull request Aug 28, 2025
Closed
@github-actions github-actions bot added the t-analysis Analysis (normed *, calculus) label Aug 28, 2025
@Timeroot Timeroot added the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 28, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 28, 2025 •
edited
Loading

PR summary c59884f91e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Convex.lift
+ Sbtw.lift
+ Wbtw.lift
+ affineSegment.lift
+ openSegment.lift
+ segment.lift

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 28, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 28, 2025
@Timeroot Timeroot requested a review from j-loreaux August 28, 2025 21:24
@Timeroot Timeroot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 28, 2025
@Timeroot
Copy link
Copy Markdown
Collaborator Author

Timeroot commented Aug 28, 2025

Jireh, I took it me a while to get back to this but here you are :)

@mathlib4-merge-conflict-bot
Copy link
Copy Markdown
Collaborator

mathlib4-merge-conflict-bot commented Aug 29, 2025

This pull request has conflicts, please merge master and resolve them.

@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 29, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 29, 2025
j-loreaux
j-loreaux approved these changes Sep 2, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Sep 2, 2025
mathlib-bors bot pushed a commit that referenced this pull request Sep 2, 2025
@Timeroot
feat(Analysis/Convex): Lifting convex sets along scalar towers (#29075)
9960e63 
This PR continues the work from #25637.

Original PR: #25637
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 2, 2025

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Sep 2, 2025
@Timeroot
feat(Analysis/Convex): Lifting convex sets along scalar towers (#29075)
f033e7e 
This PR continues the work from #25637.

Original PR: #25637
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 2, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Analysis/Convex): Lifting convex sets along scalar towers [Merged by Bors] - feat(Analysis/Convex): Lifting convex sets along scalar towers Sep 2, 2025
@mathlib-bors mathlib-bors bot closed this Sep 2, 2025
@mans0954 mans0954 mentioned this pull request Sep 4, 2025
Closed
CBirkbeck pushed a commit to CBirkbeck/mathlib4 that referenced this pull request Sep 8, 2025
@Timeroot @CBirkbeck
feat(Analysis/Convex): Lifting convex sets along scalar towers (leanp…
838fe95 
…rover-community#29075)

This PR continues the work from leanprover-community#25637.

Original PR: leanprover-community#25637
yuanyi-350 pushed a commit to yuanyi-350/yuanyi_mathlib4 that referenced this pull request Sep 10, 2025
@Timeroot @yuanyi-350
feat(Analysis/Convex): Lifting convex sets along scalar towers (leanp…
ab62c39 
…rover-community#29075)

This PR continues the work from leanprover-community#25637.

Original PR: leanprover-community#25637
robertmaxton42 pushed a commit to robertmaxton42/mathlib4 that referenced this pull request Sep 11, 2025
@Timeroot @robertmaxton42
feat(Analysis/Convex): Lifting convex sets along scalar towers (leanp…
30a711c 
…rover-community#29075)

This PR continues the work from leanprover-community#25637.

Original PR: leanprover-community#25637
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Oct 2, 2025
@Timeroot @joelriou
feat(Analysis/Convex): Lifting convex sets along scalar towers (leanp…
d58aeca 
…rover-community#29075)

This PR continues the work from leanprover-community#25637.

Original PR: leanprover-community#25637
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-loreaux j-loreaux j-loreaux approved these changes

Assignees

No one assigned

Labels

ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Timeroot @mathlib4-merge-conflict-bot @j-loreaux