Skip to content

[Merged by Bors] - feat: filter_disjiUnion#28443

Closed
mitchell-horner wants to merge 3 commits intoleanprover-community:masterfrom
mitchell-horner:disjiUnion-results
Closed

[Merged by Bors] - feat: filter_disjiUnion#28443
mitchell-horner wants to merge 3 commits intoleanprover-community:masterfrom
mitchell-horner:disjiUnion-results

Conversation

@mitchell-horner
Copy link
Copy Markdown
Collaborator


Needed for a proof of the Erdős-Stone-Simonovits theorem in future PR.

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 14, 2025

PR summary 28844c3b8c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ filter_disjiUnion
+ pairwiseDisjoint_filter

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Aug 14, 2025
(s.disjiUnion t h).fold op (s.fold op b₀ b) f = s.fold op b₀ fun i => (t i).fold op (b i) f :=
(congr_arg _ <| Multiset.map_bind _ _ _).trans (Multiset.fold_bind _ _ _ _ _)

private lemma pairwiseDisjoint_filter {f : α → Finset β} (h : (↑s : Set α).PairwiseDisjoint f)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this private?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't have to be. I just saw this lemma above

private lemma pairwiseDisjoint_fibers : Set.PairwiseDisjoint ↑t fun a ↦ s.filter (f · = a) := ...

that serves a similar purpose is private.

Copy link
Copy Markdown
Contributor

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Aug 26, 2025
mathlib-bors bot pushed a commit that referenced this pull request Aug 26, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 26, 2025

Pull request successfully merged into master.

Build succeeded:

  • CI Success

@mathlib-bors mathlib-bors bot changed the title feat: filter_disjiUnion [Merged by Bors] - feat: filter_disjiUnion Aug 26, 2025
@mathlib-bors mathlib-bors bot closed this Aug 26, 2025
@mitchell-horner mitchell-horner deleted the disjiUnion-results branch August 26, 2025 08:28
FormulaRabbit81 pushed a commit to YaelDillies/mathlib4 that referenced this pull request Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants