[Merged by Bors] - fix: generalize CommSemiring to Semiring for bilinear map composition#26458
Closed
eric-wieser wants to merge 5 commits intomasterfrom
Closed
[Merged by Bors] - fix: generalize CommSemiring to Semiring for bilinear map composition#26458eric-wieser wants to merge 5 commits intomasterfrom
CommSemiring to Semiring for bilinear map composition#26458eric-wieser wants to merge 5 commits intomasterfrom
Conversation
…tion This file could do with further variable cleanup, but that's left for a later PR.
eric-wieser
added
the
awaiting-CI
PR summary 9858d11442Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
github-actions
bot
removed
the
awaiting-CI
Member
Author
|
!bench |
eric-wieser
commented
Jun 26, 2025
| rfl | ||
|
|
||
| @[simp] | ||
| theorem compl₂_apply (g : Q →ₛₗ[σ₄₂] N) (m : M) (q : Q) : f.compl₂ g m q = f m (g q) := rfl |
Member
Author
There was a problem hiding this comment.
Previously this was less general than the definition
Collaborator
|
Here are the benchmark results for commit 09fe2f6. |
|
Contributor
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
ghost
added
the
delegated
Co-authored-by: Bhavik Mehta <[email protected]>
Member
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 27, 2025
…tion (#26458) This file could do with further variable cleanup, but that's left for a later PR. I needed some of these generalizations for some base change results.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
CommSemiring to Semiring for bilinear map compositionCommSemiring to Semiring for bilinear map composition
3 tasks
joelriou
pushed a commit
to joelriou/mathlib4
that referenced
this pull request
Jul 7, 2025
…tion (leanprover-community#26458) This file could do with further variable cleanup, but that's left for a later PR. I needed some of these generalizations for some base change results.
1 task
alreadydone
added a commit
that referenced
this pull request
Jul 7, 2025
alreadydone
reviewed
Jul 7, 2025
| def lcomp (f : M →ₗ[R] Nₗ) : (Nₗ →ₗ[R] Pₗ) →ₗ[A] M →ₗ[R] Pₗ := | ||
| letI := SMulCommClass.symm | ||
| flip <| LinearMap.comp (flip id) f | ||
| def lcomp (f : M →ₗ[R] Nₗ) : (Nₗ →ₗ[R] Pₗ) →ₗ[A] M →ₗ[R] Pₗ := lcompₛₗ _ _ _ f |
Contributor
There was a problem hiding this comment.
Hmm, R is not generalized to Semiring here. I have to do it again in #24015 ...
callesonne
pushed a commit
to callesonne/mathlib4
that referenced
this pull request
Jul 24, 2025
…tion (leanprover-community#26458) This file could do with further variable cleanup, but that's left for a later PR. I needed some of these generalizations for some base change results.
hrmacbeth
pushed a commit
to szqzs/mathlib4
that referenced
this pull request
Jul 28, 2025
…tion (leanprover-community#26458) This file could do with further variable cleanup, but that's left for a later PR. I needed some of these generalizations for some base change results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file could do with further variable cleanup, but that's left for a later PR.
I needed some of these generalizations for some base change results.