[Merged by Bors] - fix(HahnSeries): restore a generalization lost in a merge#25412
Closed
eric-wieser wants to merge 1 commit intomasterfrom
Closed
[Merged by Bors] - fix(HahnSeries): restore a generalization lost in a merge#25412eric-wieser wants to merge 1 commit intomasterfrom
eric-wieser wants to merge 1 commit intomasterfrom
Conversation
Also avoid using IsAddUnit when the unit can be constructed directly.
PR summary 281c753cafImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
2 tasks
grunweg
approved these changes
Jun 4, 2025
Contributor
grunweg
left a comment
grunweg
left a comment
There was a problem hiding this comment.
Looks good to me. Perhaps Scott should be given time to weigh in.
maintainer merge?
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
github-actions
bot
added
the
maintainer-merge
Contributor
|
✌️ ScottCarnahan can now approve this pull request. To approve and merge a pull request, simply reply with |
ghost
added
delegated
Collaborator
|
Thanks for catching this, and for the refinement. bors r+ |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
joelriou
pushed a commit
that referenced
this pull request
Jun 8, 2025
TOMILO87
pushed a commit
that referenced
this pull request
Jun 8, 2025
callesonne
pushed a commit
to callesonne/mathlib4
that referenced
this pull request
Jul 24, 2025
…-community#25412) This restores a change from leanprover-community#22284 that was accidentally reverted in leanprover-community#20594. Also avoid using IsAddUnit when the unit can be constructed directly, which gives better defeqs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores a change from #22284 that was accidentally reverted in #20594.
Also avoid using IsAddUnit when the unit can be constructed directly, which gives better defeqs.