Skip to content

[Merged by Bors] - feat: Scott topology on a preorder#2508

Closed
mans0954 wants to merge 262 commits intomasterfrom
mans0954/scott-topology
Closed

[Merged by Bors] - feat: Scott topology on a preorder#2508
mans0954 wants to merge 262 commits intomasterfrom
mans0954/scott-topology

Conversation

@mans0954
Copy link
Copy Markdown
Collaborator

@mans0954 mans0954 commented Feb 26, 2023

Introduce the Scott topology on a preorder, defined in terms of directed sets.

There is already a related notion of Scott topology defined in topology.omega_complete_partial_order, where it is defined on ω-complete partial orders in terms of ω-chains. In some circumstances the definition given here coincides with that given in topology.omega_complete_partial_order but in general they are different. Abramsky and Jung ([Domain Theory, 2.2.4][abramsky_gabbay_maibaum_1994]) argue that the ω-chain approach has pedagogical advantages, but the directed sets approach is more appropriate as a theoretical foundation.


Previously submitted to mathlib leanprover-community/mathlib3#18448

Open in Gitpod

@mans0954
Copy link
Copy Markdown
Collaborator Author

@YaelDillies docs/references.bib doesn't seem to have been ported yet, so not sure what I should do with the additional reference?

@YaelDillies
Copy link
Copy Markdown
Contributor

Uh, not sure. Please bring it up on Zulip.

@mans0954 mans0954 marked this pull request as ready for review February 27, 2023 22:21
@kim-em kim-em added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 28, 2023
bors bot pushed a commit to leanprover-community/mathlib3 that referenced this pull request Apr 20, 2023
We prove an insert result for directed sets when the relation is reflexive. This is then used to show that a Scott continuous function is monotone.

This result is required in the [construction of the Scott topology on a preorder](leanprover-community/mathlib4#2508) (see also #18448).

Holding PR for mathlib4: leanprover-community/mathlib4#2543



Co-authored-by: Christopher Hoskin <[email protected]>
Co-authored-by: Eric Wieser <[email protected]>
bors bot pushed a commit that referenced this pull request Apr 24, 2023
Matches leanprover-community/mathlib3#18517

This result is required in #2508.



Co-authored-by: Yaël Dillies <[email protected]>
Co-authored-by: Eric Wieser <[email protected]>
@kim-em kim-em removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 24, 2023
@mans0954 mans0954 requested a review from YaelDillies April 24, 2023 06:39
@YaelDillies
Copy link
Copy Markdown
Contributor

General design question: Why are you not doing the same thing as with the lower topology? namely define a typeclass for a topology on a preorder to be the Scott topology, and then define a type synonym equipping a preorder with that topology. Here you have the synonym but not the typeclass.

@mans0954
Copy link
Copy Markdown
Collaborator Author

General design question: Why are you not doing the same thing as with the lower topology? namely define a typeclass for a topology on a preorder to be the Scott topology, and then define a type synonym equipping a preorder with that topology. Here you have the synonym but not the typeclass.

For the Lower Topology I needed the typeclass to prove this result and ultimately continuity of the inf. I haven't needed to show that something is an instance of the Scott Topology yet. I was going to introduce the typeclass as and when the need arose - but I'm happy to add it preemptively if that's the right thing to do?

@YaelDillies
Copy link
Copy Markdown
Contributor

Yes, this sounds like the correct design decision.

@mans0954
Copy link
Copy Markdown
Collaborator Author

Yes, this sounds like the correct design decision.

@YaelDillies - just to be certain - is that yes to when the need arises or yes to add preemptively? Thanks.

@YaelDillies
Copy link
Copy Markdown
Contributor

Yes to add it preemptively. Changing the design after the fact isn't a drop-in replacement (some refactors can be postponed because they are drop-in replacements), so I would like us to get it right straight away.

@kim-em kim-em added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Apr 24, 2023
@YaelDillies
Copy link
Copy Markdown
Contributor

Okay, done. Tell me what you think.

@mans0954
Copy link
Copy Markdown
Collaborator Author

mans0954 commented Dec 7, 2023

Okay, done. Tell me what you think.

Looks good - I made a couple of minor suggestions.

I also pushed this commit - you can revert it if you don't like it.

@mans0954 mans0954 added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Dec 7, 2023
@YaelDillies YaelDillies force-pushed the mans0954/scott-topology branch from 833c436 to ae44135 Compare December 7, 2023 22:04
@YaelDillies YaelDillies force-pushed the mans0954/scott-topology branch from 2b32c1e to d61afe6 Compare December 7, 2023 22:06
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've incorporated your last commit by turning the equalities of predicates into lemmas. I've thus dropped the CompleteLattice sections about IsScott since they can now easily be derived from the two new lemmas.

Since you're happy with my cleanup and I'm mostly happy with the state of this PR, let's merge. Thank you, and sorry that it took so long!

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 7, 2023

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@YaelDillies YaelDillies changed the title feat(Topology/Order/ScottTopology): Introduce the Scott topology on a preorder feat: Scott topology on a preorder Dec 7, 2023
@PatrickMassot
Copy link
Copy Markdown
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Dec 7, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 7, 2023
Introduce the Scott topology on a preorder, defined in terms of directed sets.

There is already a related notion of Scott topology defined in `topology.omega_complete_partial_order`, where it is defined on ω-complete partial orders in terms of ω-chains. In some circumstances the definition given here coincides with that given in `topology.omega_complete_partial_order` but in general they are different. Abramsky and Jung ([Domain Theory, 2.2.4][abramsky_gabbay_maibaum_1994]) argue that the ω-chain approach has pedagogical advantages, but the directed sets approach is more appropriate as a theoretical foundation.



Co-authored-by: Yaël Dillies <[email protected]>
Co-authored-by: Christopher Hoskin <[email protected]>
Co-authored-by: Mario Carneiro <[email protected]>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 7, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: Scott topology on a preorder [Merged by Bors] - feat: Scott topology on a preorder Dec 7, 2023
@mathlib-bors mathlib-bors bot closed this Dec 7, 2023
@mathlib-bors mathlib-bors bot deleted the mans0954/scott-topology branch December 7, 2023 23:51
@mans0954
Copy link
Copy Markdown
Collaborator Author

mans0954 commented Dec 8, 2023

I've incorporated your last commit by turning the equalities of predicates into lemmas. I've thus dropped the CompleteLattice sections about IsScott since they can now easily be derived from the two new lemmas.

That's fine.

Since you're happy with my cleanup and I'm mostly happy with the state of this PR, let's merge. Thank you, and sorry that it took so long!

Thank you for the huge amount of work you've put into this! I never imagined it would take this much effort when I started. Sorry that I need so much hand-holding.

Christopher

awueth pushed a commit that referenced this pull request Dec 19, 2023
Introduce the Scott topology on a preorder, defined in terms of directed sets.

There is already a related notion of Scott topology defined in `topology.omega_complete_partial_order`, where it is defined on ω-complete partial orders in terms of ω-chains. In some circumstances the definition given here coincides with that given in `topology.omega_complete_partial_order` but in general they are different. Abramsky and Jung ([Domain Theory, 2.2.4][abramsky_gabbay_maibaum_1994]) argue that the ω-chain approach has pedagogical advantages, but the directed sets approach is more appropriate as a theoretical foundation.



Co-authored-by: Yaël Dillies <[email protected]>
Co-authored-by: Christopher Hoskin <[email protected]>
Co-authored-by: Mario Carneiro <[email protected]>
mathlib-bors bot pushed a commit that referenced this pull request May 4, 2024
… Mathlib (#11710)

Introduces the Lawson Topology on a preorder.

The Lawson Topology is defined as the meet of the [Lower Topology](leanprover-community/mathlib3#17426) and the [Scott Topology](#2508) previously introduced.

A basis for the Lawson Topology is defined and some basic results are established:

- An upper set is Lawson open if and only if it is Scott open
- A lower set is Lawson closed if and only if it is closed under sups of directed sets
- The Lawson topology on a partial order is T₀ 



Co-authored-by: Christopher Hoskin <[email protected]>
Co-authored-by: Christopher Hoskin <[email protected]>
apnelson1 pushed a commit that referenced this pull request May 12, 2024
… Mathlib (#11710)

Introduces the Lawson Topology on a preorder.

The Lawson Topology is defined as the meet of the [Lower Topology](leanprover-community/mathlib3#17426) and the [Scott Topology](#2508) previously introduced.

A basis for the Lawson Topology is defined and some basic results are established:

- An upper set is Lawson open if and only if it is Scott open
- A lower set is Lawson closed if and only if it is closed under sups of directed sets
- The Lawson topology on a partial order is T₀ 



Co-authored-by: Christopher Hoskin <[email protected]>
Co-authored-by: Christopher Hoskin <[email protected]>
callesonne pushed a commit that referenced this pull request May 16, 2024
… Mathlib (#11710)

Introduces the Lawson Topology on a preorder.

The Lawson Topology is defined as the meet of the [Lower Topology](leanprover-community/mathlib3#17426) and the [Scott Topology](#2508) previously introduced.

A basis for the Lawson Topology is defined and some basic results are established:

- An upper set is Lawson open if and only if it is Scott open
- A lower set is Lawson closed if and only if it is closed under sups of directed sets
- The Lawson topology on a partial order is T₀ 



Co-authored-by: Christopher Hoskin <[email protected]>
Co-authored-by: Christopher Hoskin <[email protected]>
mathlib-bors bot pushed a commit that referenced this pull request Oct 13, 2024
…ogy (#16523)

Unify Scott Topologies, following on from #13201 and #16826.

Originally Mathlib had a notion of ω-Scott Continuity and ω-Scott Topology based on Chains for ω-complete partial orders. Previously we introduced a notion of Scott Continuity and Scott Topology based on directed sets for arbitrary pre-orders (#2508). In #13201, we generalised our definition of Scott Continuity to include ω-Scott Continuity as a special case. This PR continues that work by generalising our notion of Scott Topology to include ω-Scott Topology as a special case.

`Topology.IsScott.scottContinuous_iff_continuous` and `Topology.IsScott.ωscottContinuous_iff_continuous` have almost identical proofs and are presumably special cases of a more general result that I have not yet formulated. However I think this PR covers enough ground to be worth considering at this stage.



Co-authored-by: Christopher Hoskin <[email protected]>
Co-authored-by: Christopher Hoskin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-order Order theory t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants