Skip to content

refactor(CategoryTheory): redefine triangulated subcategories using ObjectProperty#24191

Closed
joelriou wants to merge 31 commits intomasterfrom
object-property-triangulated-subcategory
Closed

refactor(CategoryTheory): redefine triangulated subcategories using ObjectProperty#24191
joelriou wants to merge 31 commits intomasterfrom
object-property-triangulated-subcategory

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented Apr 19, 2025

@joelriou joelriou added WIP Work in progress t-category-theory Category theory labels Apr 19, 2025
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Apr 19, 2025
@joelriou joelriou changed the title refactor(CategoryTheory): redefine triangulatd subcategories using ObjectProperty refactor(CategoryTheory): redefine triangulated subcategories using ObjectProperty Apr 19, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 19, 2025

PR summary e669d7ecfa

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.CategoryTheory.Triangulated.Subcategory 1148 1150 +2 (+0.17%)
Mathlib.CategoryTheory.Triangulated.HomologicalFunctor 1188 1190 +2 (+0.17%)
Mathlib.Algebra.Homology.DerivedCategory.Basic 1299 1301 +2 (+0.15%)
Import changes for all files
Files Import difference
22 files Mathlib.Algebra.Homology.DerivedCategory.Basic Mathlib.Algebra.Homology.DerivedCategory.ExactFunctor Mathlib.Algebra.Homology.DerivedCategory.Ext.Basic Mathlib.Algebra.Homology.DerivedCategory.Ext.EnoughInjectives Mathlib.Algebra.Homology.DerivedCategory.Ext.EnoughProjectives Mathlib.Algebra.Homology.DerivedCategory.Ext.ExactSequences Mathlib.Algebra.Homology.DerivedCategory.Ext.ExtClass Mathlib.Algebra.Homology.DerivedCategory.Fractions Mathlib.Algebra.Homology.DerivedCategory.FullyFaithful Mathlib.Algebra.Homology.DerivedCategory.HomologySequence Mathlib.Algebra.Homology.DerivedCategory.ShortExact Mathlib.Algebra.Homology.DerivedCategory.SingleTriangle Mathlib.Algebra.Homology.HomotopyCategory.HomologicalFunctor Mathlib.Algebra.Homology.HomotopyCategory.ShortExact Mathlib.CategoryTheory.Abelian.Projective.Dimension Mathlib.CategoryTheory.Sites.SheafCohomology.Basic Mathlib.CategoryTheory.Triangulated.Adjunction Mathlib.CategoryTheory.Triangulated.HomologicalFunctor Mathlib.CategoryTheory.Triangulated.Opposite.Functor Mathlib.CategoryTheory.Triangulated.Opposite.Pretriangulated Mathlib.CategoryTheory.Triangulated.Subcategory Mathlib.CategoryTheory.Triangulated.Yoneda
2

Declarations diff

+ IsStableUnderShift
+ IsStableUnderShiftBy
+ IsTriangulated
+ IsTriangulatedClosed₁
+ IsTriangulatedClosed₁.mk'
+ IsTriangulatedClosed₂
+ IsTriangulatedClosed₂.mk'
+ IsTriangulatedClosed₃
+ IsTriangulatedClosed₃.mk'
+ ext_of_isTriangulatedClosed₁
+ ext_of_isTriangulatedClosed₁'
+ ext_of_isTriangulatedClosed₂
+ ext_of_isTriangulatedClosed₂'
+ ext_of_isTriangulatedClosed₃
+ ext_of_isTriangulatedClosed₃'
+ ext₂'
+ instance (a : A) [P.IsStableUnderShiftBy a] :
+ instance : (subcategoryAcyclic C).IsClosedUnderIsomorphisms := by
+ instance : (subcategoryAcyclic C).IsTriangulated := by
+ instance : F.homologicalKernel.IsClosedUnderIsomorphisms
+ instance : F.homologicalKernel.IsTriangulated
+ instance : P.trW.RespectsIso
+ instance : Qh.IsLocalization (HomotopyCategory.subcategoryAcyclic C).trW := by
+ instance [IsTriangulated C] [P.IsTriangulated] : P.trW.HasLeftCalculusOfFractions
+ instance [IsTriangulated C] [P.IsTriangulated] : P.trW.HasRightCalculusOfFractions
+ instance [IsTriangulated C] [P.IsTriangulated] : P.trW.IsCompatibleWithTriangulation := ⟨by
+ instance [IsTriangulated C] [P.IsTriangulated] : P.trW.IsMultiplicative
+ instance [P.ContainsZero] : P.isoClosure.ContainsZero
+ instance [P.ContainsZero] : P.trW.ContainsIdentities := by
+ instance [P.IsStableUnderShift A] :
+ instance [P.IsStableUnderShift ℤ] : P.trW.IsCompatibleWithShift ℤ
+ instance [P.IsTriangulatedClosed₂] : P.isoClosure.IsTriangulatedClosed₂
+ instance [P.IsTriangulated] : P.IsTriangulatedClosed₁
+ instance [P.IsTriangulated] : P.IsTriangulatedClosed₃
+ instance [P.IsTriangulated] : P.isoClosure.IsTriangulated
+ le_shift
+ mem_homologicalKernel_trW_iff
+ prop_shift_iff_of_isStableUnderShift
+ smul_mem_trW_iff
+ trW
+ trW.mk
+ trW.mk'
+ trW.shift
+ trW.unshift
+ trW_iff
+ trW_iff'
+ trW_iff_of_distinguished
+ trW_isoClosure
+ trW_of_isIso
- instance : (mk' P zero shift ext₂).P.IsClosedUnderIsomorphisms
- instance : (subcategoryAcyclic C).P.IsClosedUnderIsomorphisms := by
- instance : Qh.IsLocalization (HomotopyCategory.subcategoryAcyclic C).W := by
- instance : S.W.ContainsIdentities := by
- instance : S.W.IsCompatibleWithShift ℤ
- instance : S.isoClosure.P.IsClosedUnderIsomorphisms := by
- instance [F.IsHomological] : F.homologicalKernel.P.IsClosedUnderIsomorphisms := by
- instance [IsTriangulated C] : S.W.HasLeftCalculusOfFractions
- instance [IsTriangulated C] : S.W.HasRightCalculusOfFractions
- instance [IsTriangulated C] : S.W.IsCompatibleWithTriangulation := ⟨by
- instance [IsTriangulated C] : S.W.IsMultiplicative
- isoClosure
- of
- respectsIso_W
- zero

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 19, 2025
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 22, 2025
@leanprover-community-bot-assistant
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 23, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

@github-actions github-actions bot removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) large-import Automatically added label for PRs with a significant increase in transitive imports labels Apr 23, 2025
@joelriou joelriou removed the WIP Work in progress label Apr 23, 2025
@leanprover-community-bot-assistant
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 3, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 3, 2025
@leanprover-community-bot-assistant
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 12, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 12, 2025
@joelriou
Copy link
Copy Markdown
Contributor Author

This PR has been migrated to a fork-based workflow: #25931

@joelriou joelriou closed this Jun 15, 2025
@YaelDillies YaelDillies deleted the object-property-triangulated-subcategory branch August 18, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants