Skip to content

[Merged by Bors] - feature(Analysis/LocallyConvex/Polar): Polar is weak*-closed#22352

Closed
mans0954 wants to merge 2 commits intomasterfrom
mans0954/polar_weak-star-closed
Closed

[Merged by Bors] - feature(Analysis/LocallyConvex/Polar): Polar is weak*-closed#22352
mans0954 wants to merge 2 commits intomasterfrom
mans0954/polar_weak-star-closed

Conversation

@mans0954
Copy link
Copy Markdown
Collaborator

Show that the polar is weak*-closed.

Contributes to the proof of the bipolar theorem #21002, #20843


Open in Gitpod

@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Feb 27, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 27, 2025

PR summary da2658fb2a

Import changes exceeding 2%

% File
+4.54% Mathlib.Analysis.LocallyConvex.Polar

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Analysis.LocallyConvex.Polar 1322 1382 +60 (+4.54%)
Import changes for all files
Files Import difference
Mathlib.Analysis.LocallyConvex.Polar 60

Declarations diff

+ polar_eq_biInter_preimage
+ polar_isClosed

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-analysis Analysis (normed *, calculus) label Feb 27, 2025
@mans0954
Copy link
Copy Markdown
Collaborator Author

#find_home! polar_isClosed says [Mathlib].

Copy link
Copy Markdown
Contributor

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the import increase is okay here; the import seems reasonable.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 28, 2025

✌️ mans0954 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Feb 28, 2025
@mans0954
Copy link
Copy Markdown
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Feb 28, 2025
Show that the polar is weak*-closed.

Contributes to the proof of the bipolar theorem #21002, #20843



Co-authored-by: Christopher Hoskin <[email protected]>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 28, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feature(Analysis/LocallyConvex/Polar): Polar is weak*-closed [Merged by Bors] - feature(Analysis/LocallyConvex/Polar): Polar is weak*-closed Feb 28, 2025
@mathlib-bors mathlib-bors bot closed this Feb 28, 2025
@mathlib-bors mathlib-bors bot deleted the mans0954/polar_weak-star-closed branch February 28, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). large-import Automatically added label for PRs with a significant increase in transitive imports t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants