[Merged by Bors] - chore(Topology): rename CWComplex.mapsto to CWComplex.mapsTo#22106
Closed
peabrainiac wants to merge 1 commit intomasterfrom
Closed
[Merged by Bors] - chore(Topology): rename CWComplex.mapsto to CWComplex.mapsTo#22106peabrainiac wants to merge 1 commit intomasterfrom
CWComplex.mapsto to CWComplex.mapsTo#22106peabrainiac wants to merge 1 commit intomasterfrom
Conversation
peabrainiac
added
the
t-topology
PR summary b7f1232446Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
grunweg
reviewed
Feb 19, 2025
Contributor
grunweg
left a comment
grunweg
left a comment
There was a problem hiding this comment.
I tend to err on the side of caution, i.e. deprecations. (Two weeks is above my personal threshold; "three days" would be fine.) Otherwise, LGTM - thanks!
maintainer delegate
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
github-actions
bot
added
the
maintainer-merge
Member
|
Thanks! bors merge |
ghost
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 20, 2025
) Renames `RelCWComplex.mapsto` and `CWComplex.mapsto` to be more in line with the naming convention; see [zulip](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Naming.20convention/near/500709791).
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
CWComplex.mapsto to CWComplex.mapsToCWComplex.mapsto to CWComplex.mapsTo
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 20, 2025
Forgotten in #22106.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames
RelCWComplex.mapstoandCWComplex.mapstoto be more in line with the naming convention; see zulip.Since this is a leaf file and less than two weeks old I didn't add deprecation aliases - I can also add them if this is a concern though.