[Merged by Bors] - feat: add Is{Open,Closed}Embedding.sum_elim by grunweg · Pull Request #22070 · leanprover-community/mathlib4

grunweg · 2025-02-19T09:00:08Z

The necessary pieces are all in mathlib (for the open and/or the closed case), this is just a matter of putting them together. This comes up when constructing the smooth boundary of a disjoint union.

Extracted from #22059; from my bordism theory project.

The necessary pieces are all in mathlib (for the open and/or the closed case), this is just a matter of putting them together. This comes up when constructing the smooth boundary of a disjoint union. Extracted from #22059; from my bordism theory project.

github-actions · 2025-02-19T09:01:10Z

PR summary f90b21479f

Import changes for modified files

No significant changes to the import graph

Import changes for all files

Files	Import difference

Declarations diff

+ IsClosedEmbedding.sum_elim
+ IsClosedMap.sumMap
+ IsClosedMap.sum_elim
+ IsOpenEmbedding.sum_elim
+ isClosedEmbedding_iff_continuous_injective_isClosedMap
+ isClosedMap_inl
+ isClosedMap_inr
+ isClosedMap_sum_elim

You can run this locally as follows

## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary

The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Ruben-VandeVelde

maintainer delegate

Mathlib/Topology/Maps/Basic.lean

github-actions · 2025-02-19T15:18:20Z

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

Co-authored-by: Ruben Van de Velde <[email protected]>

ADedecker

Thanks!

bors d+

Mathlib/Topology/Constructions.lean

mathlib-bors · 2025-02-20T09:31:27Z

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Co-authored-by: Anatole Dedecker <[email protected]>

grunweg · 2025-02-20T10:02:02Z

Thanks for the fast review!
bors merge

The necessary pieces are all in mathlib (for the open and/or the closed case), this is just a matter of putting them together. This comes up when constructing the smooth boundary of a disjoint union. Extracted from #22059; from my bordism theory project. Co-authored-by: grunweg <[email protected]>

mathlib-bors · 2025-02-20T10:21:50Z

This PR was included in a batch that was canceled, it will be automatically retried

The necessary pieces are all in mathlib (for the open and/or the closed case), this is just a matter of putting them together. This comes up when constructing the smooth boundary of a disjoint union. Extracted from #22059; from my bordism theory project. Co-authored-by: grunweg <[email protected]>

mathlib-bors · 2025-02-20T11:10:57Z

Pull request successfully merged into master.

Build succeeded:

Per [zulip discussion](https://leanprover.zulipchat.com/#narrow/channel/116395-maths/topic/.7BIsInducing.2CIsEmbedding.7D.2Esum_elim/near/500877183): these were merged a few hours ago, hence need no deprecations yet.

* origin/master: (823 commits) chore(Computability): fix naming of lemmas about Sum.inl, Sum.inr, Sum.casesOn (#22156) feat: `Fintype Ordering` (#22154) chore: more renamings to fit the naming convention (#22148) feat(CategoryTheory): any monomorphism in a Grothendieck abelian category is a transfinite composition of pushouts of monomorphisms in a small family (#22157) chore: rename `{Continuous., continuous_}sum_map` to `sumMap` (#22155) chore: remove initial space followed by `-/` (#22158) chore: make arg in HeightOneSpectrum.valuation explicit (#22139) feat(Data/List): `List.maximum` is monotone (#22091) chore(Combinatorics/SimpleGraph): extract WalkDecomp from Walk (#21981) feat: if a monoid M acts, then so does (s : S) with [SubmonoidClass S M] (#21123) chore: backport changes to `getElem` lemmas (#22146) feat(CategoryTheory): generating monomorphisms in Grothendieck abelian categories (#22150) feat: rename variables to fit doc (#22143) feat(CategoryTheory): IsDetecting.isIso_iff_of_mono (#22135) feat(CategoryTheory): truncations of transfinite compositions (#22149) chore: simplify a proof (#22134) feat(CategoryTheory): monomorphisms are stable under coproducts in Grothendieck abelian categories (#22133) feat(Order): Set.Ici.isSuccLimit_coe (#22103) chore(Analysis/Convex/Normed): split into smaller files (#22015) feat(Algebra/Algebra/Lie): max nilpotent ideal <= radical (#22140) refactor(LinearIndependent): refactor to use LinearIndepOn (#21886) chore: rename some more `Foo.sum_elim` -> `sumElim` (#22130) chore: rename Injective.sum_elim and friends (#22129) chore: fix naming oversight from #22070 (#22128) chore: fix spelling mistakes (#22136) feat(RingTheory/Ideal/Quotient): define transtition map between ring or module quotient by powers of ideal (#21900) fix: initialize_simps_projections print warning when projection data already exists (#20339) chore: rename ContMDiff.sum_{elim,map} (#22131) feat(CategoryTheory): characterization of injective objects in terms of lifting properties (#22104) chore(Lean,Tactic): un-indent some doc-strings (#22118) feat(Algebra/MvPolynomial): add `comp` versions of rename lemmas (#21259) chose: add deprecation (#22124) feat(CategoryTheory/Abelian/GrothendieckCategory): computing colimits in Subobject (#22123) feat(CategoryTheory/Subobject): hasCardinalLT_of_mono (#22122) feat: add `DenseRange.piMap` (#22114) feat(Algebra/Algebra/Lie): define the maximal nilpotent ideal of Lie algebras (#22061) chore(Data/Finset): don't import algebra when defining `Finset.card` (#21866) feat: a function on a discrete space is smooth (#22113) feat: commutative group objects in additive categories (#21521) style(Geometry/Manifold): remove superfluous indentation in doc-strings (#22117) chore: rename PushNeg.lean to Push.lean (#22108) feat: add Is{Open,Closed}Embedding.sum_elim (#22070) feat(RingTheory/Perfectoid): define the untilt map and generalize pretilt (#21563) feature(Topology/Algebra/Module/WeakBilin): Linear map from F into the topological dual of E with the weak topology (#21078) feat(CategoryTheory/Abelian): the exact sequence attached to a pushout square (#22110) chore(ChartedSpace.lean): group constructions together (#22107) feat(CategoryTheory/MorphismProperty): more basic API (#22099) chore(Data/Fintype): split `Fintype/Card.lean` (#21840) chore(SetTheory/Cardinal/Cofinality): make `IsStrongLimit` into a structure (#21971) feat(Combinatorics/SimpleGraph): Add a theorem about cliques in induced subgraphs (#20705) ...

@pechersky

* polynomial-sequences: (558 commits) Correct the TODO to mention IsCancelAdd which does exist. Talk about strict monotonicity instead, thanks @pechersky. Mention the TODO on li generalization to semirings. One more dedent. Same injectivity twiddling for basis. nontiviality to simplify this proof, and some dedenting. Hopefully more correct injectivity lemmas matching the naming convention. Fix the empty docstring. Update Mathlib/Algebra/Polynomial/Sequence.lean Fix the variable naming. Apply suggestions from code review chore(Computability): fix naming of lemmas about Sum.inl, Sum.inr, Sum.casesOn (#22156) feat: `Fintype Ordering` (#22154) chore: more renamings to fit the naming convention (#22148) feat(CategoryTheory): any monomorphism in a Grothendieck abelian category is a transfinite composition of pushouts of monomorphisms in a small family (#22157) chore: rename `{Continuous., continuous_}sum_map` to `sumMap` (#22155) chore: remove initial space followed by `-/` (#22158) chore: make arg in HeightOneSpectrum.valuation explicit (#22139) feat(Data/List): `List.maximum` is monotone (#22091) chore(Combinatorics/SimpleGraph): extract WalkDecomp from Walk (#21981) feat: if a monoid M acts, then so does (s : S) with [SubmonoidClass S M] (#21123) chore: backport changes to `getElem` lemmas (#22146) feat(CategoryTheory): generating monomorphisms in Grothendieck abelian categories (#22150) feat: rename variables to fit doc (#22143) feat(CategoryTheory): IsDetecting.isIso_iff_of_mono (#22135) feat(CategoryTheory): truncations of transfinite compositions (#22149) chore: simplify a proof (#22134) feat(CategoryTheory): monomorphisms are stable under coproducts in Grothendieck abelian categories (#22133) feat(Order): Set.Ici.isSuccLimit_coe (#22103) chore(Analysis/Convex/Normed): split into smaller files (#22015) feat(Algebra/Algebra/Lie): max nilpotent ideal <= radical (#22140) refactor(LinearIndependent): refactor to use LinearIndepOn (#21886) chore: rename some more `Foo.sum_elim` -> `sumElim` (#22130) chore: rename Injective.sum_elim and friends (#22129) chore: fix naming oversight from #22070 (#22128) chore: fix spelling mistakes (#22136) feat(RingTheory/Ideal/Quotient): define transtition map between ring or module quotient by powers of ideal (#21900) fix: initialize_simps_projections print warning when projection data already exists (#20339) chore: rename ContMDiff.sum_{elim,map} (#22131) feat(CategoryTheory): characterization of injective objects in terms of lifting properties (#22104) chore(Lean,Tactic): un-indent some doc-strings (#22118) feat(Algebra/MvPolynomial): add `comp` versions of rename lemmas (#21259) chose: add deprecation (#22124) feat(CategoryTheory/Abelian/GrothendieckCategory): computing colimits in Subobject (#22123) feat(CategoryTheory/Subobject): hasCardinalLT_of_mono (#22122) feat: add `DenseRange.piMap` (#22114) feat(Algebra/Algebra/Lie): define the maximal nilpotent ideal of Lie algebras (#22061) chore(Data/Finset): don't import algebra when defining `Finset.card` (#21866) feat: a function on a discrete space is smooth (#22113) feat: commutative group objects in additive categories (#21521) ...

grunweg added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Feb 19, 2025

grunweg mentioned this pull request Feb 19, 2025

feat: manifolds with smooth boundary #22059

Closed

12 tasks

grunweg added 2 commits February 19, 2025 11:14

Fix

4a811e1

Fix lint

9705f3b

Ruben-VandeVelde approved these changes Feb 19, 2025

View reviewed changes

Mathlib/Topology/Maps/Basic.lean Outdated Show resolved Hide resolved

github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Feb 19, 2025

Update Mathlib/Topology/Maps/Basic.lean

7a4fd21

Co-authored-by: Ruben Van de Velde <[email protected]>

ADedecker approved these changes Feb 20, 2025

View reviewed changes

Mathlib/Topology/Constructions.lean Outdated Show resolved Hide resolved

Mathlib/Topology/Constructions.lean Outdated Show resolved Hide resolved

ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Feb 20, 2025

Apply suggestions from code review

f90b214

Co-authored-by: Anatole Dedecker <[email protected]>

mathlib-bors bot changed the title ~~feat: add Is{Open,Closed}Embedding.sum_elim~~ [Merged by Bors] - feat: add Is{Open,Closed}Embedding.sum_elim Feb 20, 2025

mathlib-bors bot closed this Feb 20, 2025

mathlib-bors bot deleted the MR-openclosedembedding-sumelim branch February 20, 2025 11:11

grunweg added a commit that referenced this pull request Feb 20, 2025

chore: fix naming oversight from #22070

84237c3

grunweg mentioned this pull request Nov 7, 2025

feat: manifolds with smooth boundary #31351

Open

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Merged by Bors] - feat: add Is{Open,Closed}Embedding.sum_elim#22070

[Merged by Bors] - feat: add Is{Open,Closed}Embedding.sum_elim#22070
grunweg wants to merge 5 commits intomasterfrom
MR-openclosedembedding-sumelim

grunweg commented Feb 19, 2025

Uh oh!

github-actions bot commented Feb 19, 2025 •

edited

Loading

Declarations diff

Uh oh!

Ruben-VandeVelde left a comment

Uh oh!

Uh oh!

github-actions bot commented Feb 19, 2025

Uh oh!

ADedecker left a comment

Uh oh!

Uh oh!

Uh oh!

mathlib-bors bot commented Feb 20, 2025

Uh oh!

grunweg commented Feb 20, 2025

Uh oh!

mathlib-bors bot commented Feb 20, 2025

Uh oh!

mathlib-bors bot commented Feb 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

grunweg commented Feb 19, 2025

Uh oh!

github-actions bot commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR summary f90b21479f

Import changes for modified files

Declarations diff

Uh oh!

Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 19, 2025

Uh oh!

ADedecker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mathlib-bors bot commented Feb 20, 2025

Uh oh!

grunweg commented Feb 20, 2025

Uh oh!

mathlib-bors bot commented Feb 20, 2025

Uh oh!

mathlib-bors bot commented Feb 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Feb 19, 2025 •

edited

Loading