Skip to content

[Merged by Bors] - feat(Data/Finsupp/Pointwise): Add Finsupp.support_mul_subset_left/right#21835

Closed
mans0954 wants to merge 1 commit intomasterfrom
mans0954/mul_support
Closed

[Merged by Bors] - feat(Data/Finsupp/Pointwise): Add Finsupp.support_mul_subset_left/right#21835
mans0954 wants to merge 1 commit intomasterfrom
mans0954/mul_support

Conversation

@mans0954
Copy link
Copy Markdown
Collaborator

Has the advantage over Finsupp.support_mul on not requiring the [DecidableEq α] hypothesis.

Needed for #18578.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

PR summary 4ceb24f0f9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ support_mul_subset_left
+ support_mul_subset_right

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Feb 13, 2025
@YaelDillies YaelDillies changed the title feature(Data/Finsupp/Pointwise): Add Finsupp.support_mul_subset_left/right feat(Data/Finsupp/Pointwise): Add Finsupp.support_mul_subset_left/right Feb 13, 2025
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Feb 13, 2025
@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Feb 14, 2025

Thanks!

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Feb 14, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 14, 2025
…ht (#21835)

Has the advantage over `Finsupp.support_mul` on not requiring the `[DecidableEq α]` hypothesis.

Needed for #18578.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 14, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Data/Finsupp/Pointwise): Add Finsupp.support_mul_subset_left/right [Merged by Bors] - feat(Data/Finsupp/Pointwise): Add Finsupp.support_mul_subset_left/right Feb 14, 2025
@mathlib-bors mathlib-bors bot closed this Feb 14, 2025
@mathlib-bors mathlib-bors bot deleted the mans0954/mul_support branch February 14, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants