[Merged by Bors] - refactor(Cache): use module name as key instead of unresolved file path#21834
Closed
joneugster wants to merge 84 commits intomasterfrom
Closed
[Merged by Bors] - refactor(Cache): use module name as key instead of unresolved file path#21834joneugster wants to merge 84 commits intomasterfrom
joneugster wants to merge 84 commits intomasterfrom
Conversation
…rdcoded_package_dirs
…hardcoded_package_dirs
Co-authored-by: Eric Wieser <[email protected]>
…e_hardcoded_package_dirs
…rdcoded_package_dirs
…hardcoded_package_dirs
…er/cache_parse_args
joneugster
added
blocked-by-other-PR
PR summary 4ed602f84fImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
mathlib-bors
bot
changed the base branch from
eugster/cache_parse_args
to
master
joneugster
removed
the
blocked-by-other-PR
Collaborator
|
This PR/issue depends on: |
joneugster
commented
Apr 2, 2025
Contributor
Author
joneugster
left a comment
joneugster
left a comment
There was a problem hiding this comment.
A few comments to facilitate reviews:
Contributor
|
bors merge |
ghost
added
the
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 3, 2025
…th (#21834) Change internal keys of `cache` from unresolved paths like `Mathlib/Init.lean` to modules `Mathlib.Init` and keep track of the relevant source files. This helps increasing the support for `cache` in downstream projects depending on mathlib. This PR is a pure internal refactor which does not alter any behaviour of `cache`. Co-authored-by: Eric Wieser <[email protected]>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
tannerduve
pushed a commit
that referenced
this pull request
May 13, 2025
…th (#21834) Change internal keys of `cache` from unresolved paths like `Mathlib/Init.lean` to modules `Mathlib.Init` and keep track of the relevant source files. This helps increasing the support for `cache` in downstream projects depending on mathlib. This PR is a pure internal refactor which does not alter any behaviour of `cache`. Co-authored-by: Eric Wieser <[email protected]>
This was referenced Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change internal keys of
cachefrom unresolved paths likeMathlib/Init.leanto modulesMathlib.Initand keep track of the relevant source files. This helps increasing the support forcachein downstream projects depending on mathlib.This PR is a pure internal refactor which does not alter any behaviour of
cache.Tracking PR: #21238