[Merged by Bors] - feat: add QuadraticMap.associated_tmul and thus golf QuadraticForm.associated_tmul#20177
Closed
[Merged by Bors] - feat: add QuadraticMap.associated_tmul and thus golf QuadraticForm.associated_tmul#20177
QuadraticMap.associated_tmul and thus golf QuadraticForm.associated_tmul#20177Conversation
PR summary c0d04e474cImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
Contributor
|
Sorry to keep you waiting so long with this. I will review this weekend. |
Collaborator
Author
Thanks very much @ocfnash ! |
…p.IsSymm.tmul` lemma. We should have this lemma for both quadratic forms and quadratic maps since the tensor product of two quadratic forms, regarded as maps is not definitionally the same as their tensor product as forms (the former takes values in `R ⊗ R`, the latter in `R`). As a result of this, I was able to undo some of the changes to fix existing proofs which were otherwise needed adjustment. Also, I have undone the change to `LinearMap.BilinForm.baseChange`. The proposed new definition was actually defeq but less useful (and anyway was only changed to help close a proof which no longer needs this change). I have also made a set of minor style tweaks: removing redundant argument naming, enforcing "left of colon", avoiding line breaks inside terms. Finally for lemmas whose statements actually include a term of type `LinearMap.IsSymm`, I have duplicated rather than adjusting them: otherwise we are breaking the naming contract. This means a small amount of duplication is necessary but I think this is preferable: unless / until we develop very thorough and much more consistent API to unify bilinear forms and maps, we should optimise these statements for the more common case (forms).
QuadraticMap.associated_tmul and thus golf QuadraticForm.associated_tmul
ocfnash
approved these changes
Jan 25, 2025
Contributor
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 25, 2025
….associated_tmul` (#20177) Co-authored-by: Oliver Nash <[email protected]> Co-authored-by: Oliver Nash <[email protected]>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
QuadraticMap.associated_tmul and thus golf QuadraticForm.associated_tmulQuadraticMap.associated_tmul and thus golf QuadraticForm.associated_tmul
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zulip discussion: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Linear.2EIsSymm.20for.20sesquilinear.20maps
Alternative attempts to address this issue: #18406 #19809.