Skip to content

[Merged by Bors] - feat: add QuadraticMap.associated_tmul and thus golf QuadraticForm.associated_tmul#20177

Closed
mans0954 wants to merge 16 commits intomasterfrom
mans0954/QuadraticMap_associated_isSymm
Closed

[Merged by Bors] - feat: add QuadraticMap.associated_tmul and thus golf QuadraticForm.associated_tmul#20177
mans0954 wants to merge 16 commits intomasterfrom
mans0954/QuadraticMap_associated_isSymm

Conversation

@mans0954
Copy link
Copy Markdown
Collaborator

@mans0954 mans0954 commented Dec 22, 2024

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 22, 2024

PR summary c0d04e474c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ BilinMap.isSymm_iff_eq_flip
+ _root_.QuadraticForm.associated_isSymm
+ associated_tmul
+ baseChange_isSymm
+ tmul_isSymm

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Dec 22, 2024
@jcommelin jcommelin requested a review from ocfnash January 22, 2025 11:00
@ocfnash ocfnash self-assigned this Jan 22, 2025
@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Jan 22, 2025

Sorry to keep you waiting so long with this. I will review this weekend.

@mans0954
Copy link
Copy Markdown
Collaborator Author

Sorry to keep you waiting so long with this. I will review this weekend.

Thanks very much @ocfnash !

…p.IsSymm.tmul`

lemma. We should have this lemma for both quadratic forms and quadratic maps
since the tensor product of two quadratic forms, regarded as maps is not
definitionally the same as their tensor product as forms (the former takes
values in `R ⊗ R`, the latter in `R`).

As a result of this, I was able to undo some of the changes to fix existing
proofs which were otherwise needed adjustment. Also, I have undone the change to
`LinearMap.BilinForm.baseChange`. The proposed new definition was actually
defeq but less useful (and anyway was only changed to help close a proof which
no longer needs this change).

I have also made a set of minor style tweaks: removing redundant argument naming,
enforcing "left of colon", avoiding line breaks inside terms.

Finally for lemmas whose statements actually include a term of type `LinearMap.IsSymm`,
I have duplicated rather than adjusting them: otherwise we are breaking the naming
contract. This means a small amount of duplication is necessary but I think this is
preferable: unless / until we develop very thorough and much more consistent API to
unify bilinear forms and maps, we should optimise these statements for the more
common case (forms).
@ocfnash ocfnash changed the title refactor(LinearAlgebra/QuadraticForm/Basic): Make associated_isSymm work for Quadratic Maps feat: add QuadraticMap.associated_tmul and thus golf QuadraticForm.associated_tmul Jan 25, 2025
@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Jan 25, 2025

Thanks!

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jan 25, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 25, 2025
….associated_tmul` (#20177)




Co-authored-by: Oliver Nash <[email protected]>
Co-authored-by: Oliver Nash <[email protected]>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 25, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: add QuadraticMap.associated_tmul and thus golf QuadraticForm.associated_tmul [Merged by Bors] - feat: add QuadraticMap.associated_tmul and thus golf QuadraticForm.associated_tmul Jan 25, 2025
@mathlib-bors mathlib-bors bot closed this Jan 25, 2025
@mathlib-bors mathlib-bors bot deleted the mans0954/QuadraticMap_associated_isSymm branch January 25, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants